-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic rt.jar detection is likely incorrect on macOS for pre-7 versions of the JDK #1062
Comments
This would also affect the |
Given how old JDK 6 is at this point, I think it might be reasonable to simply state that we only work with versions 7 and greater. Alternatively, we could identify the whole set of (JDK version, OS, rt.jar location) triples for historical versions. Or this could be the reason to keep |
Valid points. It's perhaps a bit heavy handed to error outright if you use an old JDK, but we could document the fact that old JDKs might not adhere to modern conventions, so you may have to manually specify some locations (be it with |
Yeah, something like that sounds exactly right. |
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the `.github/PropertiesTest.java` utility, nor is there any need for the `find_java` bash function that leverages this. This patch remove both of them as well. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no longer necessary with the advent of `--java-bin-dirs`/searching the `PATH` for Java. This fixes #1061. * Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the `.github/PropertiesTest.java` utility, nor is there any need for the `find_java` bash function that leverages this. This patch remove both of them as well. * On a related note, it turns out that SAW's approach to detecting where `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how ancient these versions of Java anymore, let's just document this infelicity in the manual and describe a workaround for those brave enough to try this. Fixes #1062.
I recently came across this note in
find-java-rt-jar.sh
:saw-script/intTests/support/find-java-rt-jar.sh
Lines 3 to 4 in f8449a1
This came as a surprise to me, as I was under the impression that the JDK consistently named this file
rt.jar
. If this is the case, the logic I implemented for automatically detectingrt.jar
in #1030 is incorrect when combining macOS with JDK 6 and earlier. We should verify that this is the case and add a corresponding code path forclasses.jar
.The text was updated successfully, but these errors were encountered: