Remove find-java-rt-jar.sh, document how -b interacts with older JDKs

* Remove the use of the `find-java-rt-jar.sh` script in CI, as this is no
  longer necessary with the advent of `--java-bin-dirs`/searching the `PATH`
  for Java. This fixes #1061.

* Now that `find-java-rt-jar.sh` is gone, there is no longer any need for the
  `.github/PropertiesTest.java` utility, nor is there any need for the
  `find_java` bash function that leverages this. This patch remove both of them
  as well.

* On a related note, it turns out that SAW's approach to detecting where
  `rt.jar` lives likely doesn't work on pre-7 JDKs on macOS. Given how
  ancient these versions of Java anymore, let's just document this infelicity
  in the manual and describe a workaround for those brave enough to try this.
  Fixes #1062.

Author: RyanGlScott

.github/PropertiesTest.java

@@ -166,7 +166,6 @@ install_system_deps() {
 }
 
 test_dist() {
-  find_java
   pushd intTests
   env
   LOUD=true ./runtests.sh
@@ -197,16 +196,6 @@ bundle_files() {
   cp -r examples/* dist/examples
 }
 
-find_java() {
-  pushd .github
-  javac PropertiesTest.java
-  RT_JAR="$(java PropertiesTest | tr : '\n' | grep rt.jar | head -n 1)"
-  export RT_JAR
-  echo "RT_JAR=$RT_JAR" >> "$GITHUB_ENV"
-  rm PropertiesTest.class
-  popd
-}
-
 sign() {
   gpg --batch --import <(echo "$SIGNING_KEY")
   fingerprint="$(gpg --list-keys | grep galois -a1 | head -n1 | awk '{$1=$1};1')"

.github/ci.sh

@@ -1557,8 +1557,14 @@ control where to look for classes:
   files found in that directory (and its subdirectories) to the class database.
   By default, the current directory is included in the class path.
 
-Most Java programs will only require setting the `-b` flag, as that is enough
-to bring in the standard Java libraries.
+Most Java programs will only require setting the `-b` flag (or the `PATH`), as
+that is enough to bring in the standard Java libraries. Note that when
+searching the `PATH`, SAW makes assumptions about where the standard library
+classes live. These assumptions are likely to hold on JDK 7 or later, but they
+may not hold on older JDKs on certain operating systems. If you are using an
+old version of the JDK and SAW is unable to find a standard Java class, you may
+need to specify the location of the standard classes' JAR file with the `-j`
+flag (or, alternatively, with the `SAW_JDK_JAR` environment variable).
 
 Once the class path is configured, you can pass the name of a class to
 the `java_load_class` function.

doc/manual/manual.md

@@ -36,17 +36,17 @@ fi
 
 # Build the class path. On Windows, Java requires Windows-style paths
 # here, even in Cygwin.
-#
-# Locate rt.jar. This is already a Windows path on windows, so no need
-# to 'cygpath' it.
-JDK=$(support/find-java-rt-jar.sh)
-CP="$JDK"
+CP=""
 # Add our bundled .jars to the class path.
 for i in "$TESTBASE"/jars/*.jar; do
   if [ "$OS" == "Windows_NT" ]; then
     i=$(cygpath -w "$i")
   fi
-  CP=$CP$CPSEP$i
+  if [ -z "$CP" ]; then
+    CP=$i
+  else
+    CP=$CP$CPSEP$i
+  fi
 done
 export CP