Conversation
This commit does the following: - Resolves issues with NFT swap_v2 tests on Geth. - Updates NFT activation to utilize coins config. - Moves authentication message from Body to Header in Quicknode HTTP requests. - Adds optional `swap_v2_contracts` field for Ethereum platform coin activation.
Having lib.rs forced us to write #[path = 'file/path.rs'] directive for every module we define, even the trivial ones that didn't need no #[path]. This commit fixes this by setting mm2.rs as the root lib for mm2_main.
This commit does the following: * Adds new signature algorithm for komodo-defi-proxy (coin-agnostic, pubkey-only mode) * Refactors NFT and ETH proxy to use the new algorithm * Implements proxy support for Tendermint (including WebSocket connections) BREAKING CHANGES: * Updates to Tendermint activation payloads: - 'rpc_urls' field (previously a list of plain string values) is replaced with 'nodes' (a list of JSON objects). * All RPC methods fields controlling komodo-defi-proxy are renamed to 'komodo_proxy', this affects various activations, including ETH/EVM.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit implements EVM TPU taker methods and adds some enhancements for eth docker tests.
This comit removes any sia lib related code from kdf and uses sia-rust repo as a dependency instead. `my_balance` is also implemented for siacoin in this commit.
This commit removes zcoin additional chain validation to turn on debug assertion.
This makes coins a separate crate that can be tested and checked separately.
…eers` (#2195) `get_peers_info` RPC had a misleading name, it only returns the directly connected peers, not all network peers. This commit renames the RPC to `get_directly_connected_peers` which causes a breaking change.
KDF was creating the default all zeroes db dir on start which is not used, this commit fixes this.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Fixes an issue regarding a tokio tcp stream that breaks because it was spawned in a non-tokio runtime. the `.wait` methods were using a different runtime - from futures - to run the future. This commit uses `block_on(fut.compat())` from KDF's tokio runtime instead.
This commit introduces the `get_wallet_names` RPC method, which allows clients to retrieve information about all wallet names and the currently active one.
This commit updates GHA runners to use locked scripts rather than always using the latest one from the master branch. It also adds a new GHA helper/plugin to easily download files and verify their checksums.
This commit prevents creating messages for proxy with too long lifetimes.
…2199) This fixes the issue where taker doesn't wait for maker payment spend confirmation. Two new events were added: - "MakerPaymentSpendConfirmed": Success event, fired after "MakerPaymentSpent". - "MakerPaymentSpendConfirmFailed": Error event, means that the taker spend maker payment transaction confirmation was failed.
There is no point to keep them in the project anymore. Signed-off-by: onur-ozkan <work@onurozkan.dev>
DeckerSU
previously approved these changes
Oct 24, 2024
DeckerSU
left a comment
DeckerSU
left a comment
There was a problem hiding this comment.
All new or updated dependencies have passed the security review. No explicit malicious elements were found.
Refactors electrum client to add min/max connection controls, with server priority based on list order. Electrum client can now operate in single-server mode (1,1) to reduce resource usage (especially beneficial for mobile) or multi-server (legacy) mode for reliability. Higher priority servers automatically replace lower priority ones when reconnecting during periodic retries or when connection count drops below minimum.
…2254) Show full evm coins address in iguana v2 activation result instead of truncated address.
Organizes scattered P2P types and modules into a more suitable crate and makes them easier to maintain and accessible directly from the P2P layer
This commit fixes recover funds for taker when the swap was marked as unsuccessful due to the maker payment spend transaction not being confirmed. It also uses the required confirmations from coin config for taker/maker payment spend instead of using 1 confirmation max. This is because some chains require more than 1 confirmation for finality, e.g. Polygon.
This is to return the same type/json across all coins for GUIs since EVM uses `CoinBalanceMap`
Cosmos transaction history implementation was incorrectly parsing addresses (using the relayer address instead of the cross-chain address) from IBC transactions. This commit fixes the address parsing logic and adds test coverage for it.
…ce (#2209) This commit also fixes `withdarw_erc1155` decimal issue.
smk762
previously approved these changes
Nov 11, 2024
smk762
left a comment
smk762
left a comment
There was a problem hiding this comment.
No critical defects found during testing and documentation.
Related merged/approved docs PRS:
- GLEECBTC/komodo-docs-mdx#357
- GLEECBTC/komodo-docs-mdx#356
- GLEECBTC/komodo-docs-mdx#368
- GLEECBTC/komodo-docs-mdx#318
- GLEECBTC/komodo-docs-mdx#324
- GLEECBTC/komodo-docs-mdx#373
- GLEECBTC/komodo-docs-mdx#354
- GLEECBTC/komodo-docs-mdx#284
- GLEECBTC/komodo-docs-mdx#375
Related docs PRs awaiting review:
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Adds support for enabling custom EVM (ERC20, PLG20, etc..) tokens without requiring them to be in the coins config. This allows users to interact with any ERC20 token by providing the contract address.
This also fixes propagation of health check messages.
DeckerSU
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
The following new and updated crates were reviewed:
cosmos-sdk-proto
cosmrs
num-derive
serde_spanned
tendermint
tendermint-config
tendermint-proto
tendermint-rpc
toml
toml_datetime
toml_edit
winnow
No malicious components were found, so LGTM.
p.s. This review only covers the changed and newly introduced dependencies, as always, and does not include the mm2/kdf code itself.
smk762
approved these changes
Nov 22, 2024
smk762
left a comment
smk762
left a comment
There was a problem hiding this comment.
additional docs drafted since last approval:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
Enhancements/Fixes:
token_idfield was added to the tx history primary key. #2209get_wallet_namesRPC was added to retrieve information about all wallet names and the currently active one. #2202CoinBalanceMapfor both UTXOs and QTUM. #2259CoinBalanceMap.get_new_addressresponse after #2264wasm-optoverriding was removed. #2200Removals:
Other Changes:
.wait()usage was replaced withblock_onin tests to ensure consistent runtime usage, fixing issues with tokio TCP streams in non-tokio runtimes. #2220NB - Backwards compatibility breaking changes:
get_peers_infoRPC was renamed toget_directly_connected_peers. #2195