feat(new-RPC): connection healthcheck implementation for peers by onur-ozkan · Pull Request #2194 · GLEECBTC/komodo-defi-framework

onur-ozkan · 2024-08-20T12:38:32Z

Implement a new P2P message type, "hcheck."
Implement peer_connection_healthcheck to verify if peer X is currently connected to the KDF network.
Make the heathcheck feature configurable.
Add unit and integration tests for the new implementations.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mm2src/mm2_main/src/lp_healthcheck.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mm2src/mm2_main/src/lp_healthcheck.rs

borngraced

one question?

mm2src/mm2_core/src/mm_ctx.rs

mm2src/mm2_main/src/lp_healthcheck.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys

LGTM!
Thanks :)

mm2src/mm2_main/src/lp_healthcheck.rs

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys

Thanks, LGTM 😂

mm2src/mm2_main/src/lp_healthcheck.rs

shamardy · 2024-10-03T06:13:03Z

There seems to be a lot of changes here since my last approval, will give it another check today to make sure everything is fine, if so, will approve and merge.

shamardy

Huge work! Everything looks good to me, the below comments are just some nits, it's up to you if you want to resolve them.

Please merge with dev for failing test_electrum_tx_history to pass.

mm2src/mm2_main/src/lp_healthcheck.rs

shamardy · 2024-10-03T07:42:05Z

mm2src/mm2_main/src/lp_healthcheck.rs

+
+    {
+        let mut book = ctx.healthcheck_response_handler.lock().await;
+        book.clear_expired_entries();


This clear_expired_entries will be removed when merging with this #2232 depending on which gets merged first. Just a note :)

* dev: fix(orders): fix cancel order race condition using time-based cache (#2232) fix(legacy-swap): taker failed spend maker payment marked as failed (#2199) chore(adex-cli): deprecate adex-cli (#2234) feat(new-RPC): connection healthcheck implementation for peers (#2194) fix(proxy-signature): add message lifetime overflows (#2233) feat(CI): handle remote files in a safer way (#2217) chore(doc): update issue address in README (#2227) fix(merge): remove duplicated db_root function (#2229) feat(wallets): add `get_wallet_names` rpc (#2202) chore(tests): don't use `.wait()` and use `block_on` instead (#2220) fix(native-rpc): remove escaped response body (#2219) fix(clippy): fix coins mod clippy warnings in wasm (#2224) feat(core): handling CTRL-C signal with graceful shutdown (#2213) docs(README): fix typos (#2212) remove the non-sense arguments (#2216) fix(db): stop creating the all-zeroes dir on KDF start (#2218)

* dev: fix(cosmos): fix tx broadcasting error (#2238) chore(solana): remove solana implementation (#2239) chore(cli): remove leftover subcommands from help message (#2235) fix(orders): fix cancel order race condition using time-based cache (#2232) fix(legacy-swap): taker failed spend maker payment marked as failed (#2199) chore(adex-cli): deprecate adex-cli (#2234) feat(new-RPC): connection healthcheck implementation for peers (#2194) fix(proxy-signature): add message lifetime overflows (#2233) feat(CI): handle remote files in a safer way (#2217) chore(doc): update issue address in README (#2227) fix(merge): remove duplicated db_root function (#2229) feat(wallets): add `get_wallet_names` rpc (#2202) chore(tests): don't use `.wait()` and use `block_on` instead (#2220) fix(native-rpc): remove escaped response body (#2219) fix(clippy): fix coins mod clippy warnings in wasm (#2224) feat(core): handling CTRL-C signal with graceful shutdown (#2213) docs(README): fix typos (#2212) remove the non-sense arguments (#2216) fix(db): stop creating the all-zeroes dir on KDF start (#2218)

onur-ozkan added 2 commits August 19, 2024 18:30

create bare RPC structure

4c23204

Signed-off-by: onur-ozkan <work@onurozkan.dev>

implement PeerConnectionHealth p2p command

ad1cdb9

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan added enhancement labels Aug 20, 2024

onur-ozkan added 7 commits August 26, 2024 18:19

add new p2p message topic "hcheck"

838b5a5

Signed-off-by: onur-ozkan <work@onurozkan.dev>

fix p2p race condition

886d13e

Signed-off-by: onur-ozkan <work@onurozkan.dev>

WIP: HealtCheckMsg

9ee8485

Signed-off-by: onur-ozkan <work@onurozkan.dev>

implement signing and verification logic

db49d0d

Signed-off-by: onur-ozkan <work@onurozkan.dev>

simulate request-response behaviour

a5d7f81

Signed-off-by: onur-ozkan <work@onurozkan.dev>

improve the performance and logging

90e5599

Signed-off-by: onur-ozkan <work@onurozkan.dev>

remove redundant crates

ecf9cea

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the get-peer-rpc branch from 4f66e1b to 1d9d874 Compare August 28, 2024 08:48

onur-ozkan added 3 commits August 28, 2024 11:53

add debug logs for invalid messages

1d9d874

Signed-off-by: onur-ozkan <work@onurozkan.dev>

improve response status, error logs and types

493585a

Signed-off-by: onur-ozkan <work@onurozkan.dev>

inline various functions

f5c98da

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the get-peer-rpc branch from 5962e93 to f5c98da Compare August 28, 2024 10:15

onur-ozkan added 2 commits August 28, 2024 14:27

prevent brute-force attacks

0aaa011

Signed-off-by: onur-ozkan <work@onurozkan.dev>

handle panics

b73a0f2

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the get-peer-rpc branch from 73364f0 to b73a0f2 Compare September 2, 2024 09:05

onur-ozkan added 4 commits September 2, 2024 13:07

add unit test coverage for healthcheck implementation

e6f29c7

Signed-off-by: onur-ozkan <work@onurozkan.dev>

extend healthcheck coverage to WASM

8a20b8c

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add integration test coverage for peer_connection_healthcheck RPC

f550550

Signed-off-by: onur-ozkan <work@onurozkan.dev>

add global configuration interface for healthchecks

9774f15

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan force-pushed the get-peer-rpc branch from 1198a6d to 9774f15 Compare September 2, 2024 11:46

add doc-comments

6286299

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan marked this pull request as ready for review September 3, 2024 04:40

onur-ozkan added under review and removed in progress labels Sep 3, 2024

onur-ozkan mentioned this pull request Sep 3, 2024

check status of peers in kdf network GLEECBTC/komodo-defi-proxy#25

Merged

handle our address

14eeaee

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan mentioned this pull request Sep 26, 2024

Add docs for new RPC: peer_connection_healthcheck GLEECBTC/komodo-docs-mdx#345

Closed

mariocynicys reviewed Sep 26, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

switch back to async mutexa again

8727e52

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys reviewed Sep 26, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

borngraced reviewed Sep 30, 2024

View reviewed changes

mm2src/mm2_core/src/mm_ctx.rs Outdated Show resolved Hide resolved

mariocynicys previously approved these changes Sep 30, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

onur-ozkan added in progress and removed under review labels Sep 30, 2024

implement reusable messages

d2d9fff

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan dismissed mariocynicys’s stale review via d2d9fff September 30, 2024 15:19

reduce the healthcheck overhead

b98832c

Signed-off-by: onur-ozkan <work@onurozkan.dev>

mariocynicys previously approved these changes Oct 1, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Show resolved Hide resolved

mariocynicys reviewed Oct 2, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Outdated Show resolved Hide resolved

onur-ozkan added under review and removed in progress labels Oct 2, 2024

use more precise error type and remove sender_peer from hc message

3169081

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan dismissed mariocynicys’s stale review via 3169081 October 2, 2024 11:07

mariocynicys approved these changes Oct 2, 2024

View reviewed changes

mm2src/mm2_main/src/lp_healthcheck.rs Show resolved Hide resolved

shamardy self-requested a review October 3, 2024 06:12

shamardy approved these changes Oct 3, 2024

View reviewed changes

shamardy added docs labels Oct 3, 2024

shamardy merged commit 1f3dffa into dev Oct 3, 2024

shamardy deleted the get-peer-rpc branch October 3, 2024 18:11

smk762 removed the docs label Nov 1, 2024

shamardy mentioned this pull request Nov 19, 2024

chore(release): v2.2.0-beta #2197

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(new-RPC): connection healthcheck implementation for peers #2194

feat(new-RPC): connection healthcheck implementation for peers #2194
shamardy merged 38 commits intodevfrom
get-peer-rpc

onur-ozkan commented Aug 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Uh oh!

Uh oh!

shamardy commented Oct 3, 2024

Uh oh!

shamardy left a comment

Uh oh!

Uh oh!

shamardy Oct 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

onur-ozkan commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

borngraced left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mariocynicys left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shamardy commented Oct 3, 2024

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shamardy Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

onur-ozkan commented Aug 20, 2024 •

edited

Loading