chore(RPCs): rename get_peers_info RPC to get_directly_connected_peers#2195
Merged
chore(RPCs): rename get_peers_info RPC to get_directly_connected_peers#2195
get_peers_info RPC to get_directly_connected_peers#2195Conversation
onur-ozkan
force-pushed
the
update-get_peers_info-rpc
branch
from
c383bfb to
ab2e2f0
Compare
borngraced
reviewed
Aug 23, 2024
onur-ozkan
force-pushed
the
update-get_peers_info-rpc
branch
from
ab2e2f0 to
f06f614
Compare
onur-ozkan
changed the title
get_peers_info RPC to get_seeds_infoget_peers_info RPC to get_directly_connected_peers
shamardy
reviewed
Sep 10, 2024
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Two more minor comments.
…ate its doc Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
update-get_peers_info-rpc
branch
from
f06f614 to
98624ca
Compare
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Sep 13, 2024
* dev: chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (GLEECBTC#2195) chore(WASM-builds): remove `wasm-opt` overriding (GLEECBTC#2200) fix(coins): add p2p feature to mm2_net dependency (GLEECBTC#2210) chore(test): turn on debug assertion (GLEECBTC#2204) feat(sia): extract sia lib to external repo (GLEECBTC#2167) feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (GLEECBTC#2169) fix(cors): allow OPTIONS request to KDF server (GLEECBTC#2191) docs(README): update commit badges to use dev branch (GLEECBTC#2193) use default value for `komodo_proxy` (GLEECBTC#2192) feat(cosmos): komodo-defi-proxy support (GLEECBTC#2173)
dimxy
pushed a commit
that referenced
this pull request
Sep 13, 2024
* dev: chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (#2195) chore(WASM-builds): remove `wasm-opt` overriding (#2200) fix(coins): add p2p feature to mm2_net dependency (#2210) chore(test): turn on debug assertion (#2204) feat(sia): extract sia lib to external repo (#2167) feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (#2169) fix(cors): allow OPTIONS request to KDF server (#2191) docs(README): update commit badges to use dev branch (#2193) use default value for `komodo_proxy` (#2192) feat(cosmos): komodo-defi-proxy support (#2173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_peers_infoRPC is misleading based on its name. As documented in kdf docs, it claims "all connected peers", however, in reality it only returns the directly connected peers, not all network peers. This PR renames the RPC toget_directly_connected_peerswhich causes a breaking change. Considering this RPC isn't widely used, this impact should be affordable.