Skip to content

Add/kdf/active swaps v2#374

Merged
gcharang merged 9 commits intodevfrom
add/kdf/active_swaps-v2
Nov 25, 2024
Merged

Add/kdf/active swaps v2#374
gcharang merged 9 commits intodevfrom
add/kdf/active_swaps-v2

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Nov 3, 2024

Closes #281

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 3, 2024

Preview for merge commit: 076046e, available on cloudflare at: https://1f7503fb.komodo-docs.pages.dev/en/docs/

The `active_swaps` method returns all the swaps that are currently running on the Komodo DeFi Framework API node.

<Note>
This method has been deprecated in favor of (active\_swaps v2)\[/komodo-defi-framework/api/v20/active\_swaps]. The legacy version does not include v2 (Trading Protocol Upgrade) swap statuses in responses (it only returns uuids for these).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your linking brackets are being escaped here. So on the front-end the link isn't working.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the updates seem to be all in order.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, found the cause of this being ()[] wehere it should be [](). There were a couple other instance of this in the repo which have now also been fixed in this PR.

@github-actions
Copy link
Copy Markdown

Preview for merge commit: e43428a, available on cloudflare at: https://2cc78fc7.komodo-docs.pages.dev/en/docs/

@github-actions
Copy link
Copy Markdown

Preview for merge commit: f17c4ae, available on cloudflare at: https://6cc7f59c.komodo-docs.pages.dev/en/docs/

@github-actions
Copy link
Copy Markdown

Preview for merge commit: 4170536, available on cloudflare at: https://01c73e18.komodo-docs.pages.dev/en/docs/

@github-actions
Copy link
Copy Markdown

Preview for merge commit: 13f7bba, available on cloudflare at: https://0043735a.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit 2bdb2d0 into dev Nov 25, 2024
@gcharang gcharang deleted the add/kdf/active_swaps-v2 branch January 30, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants