Skip to content

Update/nft methods#317

Merged
gcharang merged 43 commits intodevfrom
update/nft-methods
Nov 24, 2024
Merged

Update/nft methods#317
gcharang merged 43 commits intodevfrom
update/nft-methods

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Aug 23, 2024

Continues from #270

harsenyan3 and others added 15 commits July 5, 2024 11:36
@harsenyan3
Update index.mdx
980458d
@harsenyan3
Update index.mdx
34924cf 
Indicated proxy_auth is optional and defaults to false.
@harsenyan3
Update index.mdx
7137071 
Readded BSC chain
@harsenyan3
Update index.mdx
390a850
@harsenyan3
Update index.mdx
37fa294
@harsenyan3
Update index.mdx
eafec11
@harsenyan3
Update index.mdx
7b8d674
@harsenyan3
Update index.mdx
65ee467 
fixed nft_req
@harsenyan3
Create index.mdx
ebaad1b 
Created enable_nft file (based on enable_erc20)
@harsenyan3
Merge branch 'dev' into dev
36b22f2
@harsenyan3
Update index.mdx
689cc92 
Added NftProvider object to common structures
@harsenyan3
Update index.mdx
6e825b8 
Changed activation_param definition to be a standard NftProvider object
@harsenyan3
Update index.mdx
56025b5
@harsenyan3
Update index.mdx
6e131c5
@smk762
Merge pull request #270 from harsenyan3/dev
394bc21 
NFT RPC Methods Docs update
@smk762 smk762 marked this pull request as draft August 23, 2024 04:52
@smk762 smk762 self-assigned this Aug 23, 2024
@smk762 smk762 changed the base branch from main to dev August 23, 2024 04:53
laruh
laruh suggested changes Aug 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, 1st review iteration

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2024

Preview for merge commit: 9a20ff4, available on cloudflare at: https://4c8594ea.komodo-docs.pages.dev/en/docs/

smk762 and others added 2 commits October 30, 2024 18:28
@smk762
[Bot] File and author data updated, validated and updated internal li…
517c793 
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
@gcharang
Merge pull request #365 from KomodoPlatform/lint-fix-patches/update/n…
2262176 
…ft-methods
@smk762 smk762 added the P1 Important task which needs to be completed soon label Nov 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 1, 2024

Preview for merge commit: 787cc7b, available on cloudflare at: https://0d484ee9.komodo-docs.pages.dev/en/docs/

@shamardy
Copy link
Copy Markdown

shamardy commented Nov 8, 2024

@laruh can you please check if your comments have been resolved and if you have any more comments?

@smk762 smk762 mentioned this pull request Nov 11, 2024
Merged
laruh
laruh suggested changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for the fixes, here my last notes and one note is left above

@smk762 smk762 requested a review from laruh November 14, 2024 07:38
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2024

Preview for merge commit: 99d9f4b, available on cloudflare at: https://9333fdb9.komodo-docs.pages.dev/en/docs/

laruh
laruh approved these changes Nov 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 19, 2024

Preview for merge commit: 01bd59b, available on cloudflare at: https://c05be27f.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit c1211a2 into dev Nov 24, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 24, 2024

Preview for merge commit: ee3599b, available on cloudflare at: https://aba52202.komodo-docs.pages.dev/en/docs/

@gcharang gcharang deleted the update/nft-methods branch January 30, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShantanuSharma9873 ShantanuSharma9873 ShantanuSharma9873 approved these changes

+3 more reviewers

@gcharang gcharang gcharang approved these changes

@AndrewDelaney AndrewDelaney AndrewDelaney approved these changes

@laruh laruh laruh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@smk762 smk762

Labels

awaiting merge KDF methods P1 Important task which needs to be completed soon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@smk762 @shamardy @gcharang @AndrewDelaney @laruh @ShantanuSharma9873 @harsenyan3