-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connext #429
feat: connext #429
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DELETE
Steps to test in existing environment:
|
Current result as per testing with @erkarl swap failing due to a time out:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave this a spin, the swap is failing but at least I was able to get to that point.
My steps using an existing simnet node in docker:
- connect to simnet node if not already connected
connect 03193508d52dc8235c1bf6e902dae30c6dc1823f1e3cdc3c1a97652af9142cd4fe@xud1.simnet.exchangeunion.com:28885
addcurrency ETH Connext 18 --token_address="0x0000000000000000000000000000000000000000"
addpair ETH BTC
restart xud
getinfo
- copy the connext address (as an aside, I'm thinking we should return this address when we calldeposit ETH
- get eth from faucet:
curl -H "Content-Type: application/json" -X POST -d '{"address":"0xFDe0b13b271C335cac257F3536FEeEc491286A01"}' http://35.193.71.174:9000/faucet
openchannel Connext ETH 2
orderbook
- display available orderssell 0.0001 ETH/BTC mkt
to match an existing buy order
Swap failed, log output below:
22/04/2020 19:13:49.017 [SWAPS] debug: Requesting deal: {"takerCltvDelta":40,"rHash":"18ad58d57d7a738de66208e84cd5efec70199d7e0c638c94d88a6545b382e9ed","orderId":"9ff8f390-84ae-11ea-b6b3-6fbbe5142802","pairId":"ETH/BTC","proposedQuantity":10000,"rPreimage":"a8b61e32679a865e305afcd84031e1eb2e1e42d530f7a80b7dacec5b6307a60c","takerCurrency":"BTC","makerCurrency":"ETH","takerAmount":10000,"makerAmount":10000,"takerUnits":10000,"makerUnits":100000000000000,"destination":"indra7FTKMbFauqFeAYkEeQ4KiEcfGxUNXMbdCEPRGaMvRBEYwSHGRx","peerPubKey":"03193508d52dc8235c1bf6e902dae30c6dc1823f1e3cdc3c1a97652af9142cd4fe","localId":"6523d270-84cd-11ea-923e-27c70e631bb7","price":1,"isBuy":true,"phase":0,"state":0,"role":0,"createTime":1587582829010}
22/04/2020 19:13:49.925 [P2P] debug: received swapAccepted from 03193508d52dc8235c1bf6e902dae30c6dc1823f1e3cdc3c1a97652af9142cd4fe (MeltWedding): {"rHash":"18ad58d57d7a738de66208e84cd5efec70199d7e0c638c94d88a6545b382e9ed","quantity":10000,"makerCltvDelta":5054}
22/04/2020 19:13:49.981 [LND-BTC] debug: added invoice of 10000 for 18ad58d57d7a738de66208e84cd5efec70199d7e0c638c94d88a6545b382e9ed with cltvExpiry 40
22/04/2020 19:14:19.563 [P2P] debug: received swapFailed from 03193508d52dc8235c1bf6e902dae30c6dc1823f1e3cdc3c1a97652af9142cd4fe (MeltWedding): {"rHash":"18ad58d57d7a738de66208e84cd5efec70199d7e0c638c94d88a6545b382e9ed","failureReason":10}
22/04/2020 19:14:19.564 [SWAPS] debug: deal 18ad58d57d7a738de66208e84cd5efec70199d7e0c638c94d88a6545b382e9ed failed due to SwapTimedOut
@sangaman can you ensure your
I updated the image, but if you had an existing data directory it wouldn't overwrite the configuration. Previously, the webhookport value was 8887. |
Fixes to be done @reliveyy
|
You can use |
More fixes for @reliveyy :
(some seconds later it's fine)
|
Other than that getting channels for all 3 currencies now 🎉
|
Here again for clarity @reliveyy :
|
local key="023f670b916d8b89e362f4832f8eeca4f2d578a737c97f6fd4845bb7b584647667" | ||
local uri="[email protected]:10011" | ||
local key="03af9876d7a367cd92d192c745194e91173830c9e4f0d51cfe19beb687189a99e5" | ||
local uri="$key@zqnr7vepxwk6w26zlmuh55edg45yu44rcqdk5d2gzfp7rtodduc6ycid.onion:30375" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URI port is still 375 (not 735)?
local key="02db09dd366d7ba6d061502b5b6db1bbb47c0daacd36fc399ab617fd6406cf822a" | ||
local uri="[email protected]:10012" | ||
local key="0331c98ab6ec199164130cca2b2118a17e7d5e8b53d4e46ddfd4b656a30c636b70" | ||
local uri="$key@5ucnksx35jjj34atausbifhyoiv7adsrjatqb5vpns6fftqaxmbvzfid.onion:29375" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here 375?
For documentation purposes: I made local1_lndbtc, xud1_lndbtc, local2_lndbtc all connect to our gcloud btcd instead of using neutrino, lndbtc's have tor natively enabled, just like before, synced local1/2 from scratch. Result: trying to pay immediately after synced to chain/graph are true results in the same failures (someimtes for both sides, but mostly only for one). After some 10 more minutes payments start working in all directions.
|
#441 (comment) How it should be:
|
Can you change the connext image tag from |
TODO:
|
Question: after backup recovering I got the same address and the same balance for ETH and XUC (but not for BTC/LTC, because I think I again got typo in passphrase and it is already starting to look suspicious and annoying for me). How the recovering works for Connext? only backup file of xud should be provided to get access to wallet? |
The seed for connext is derived from xud's seed + the I'd handle the restore/backup separately from this PR. |
Fixed by ExchangeUnion/xud#1540 |
Agree, not important for "connext on simnet", opened ExchangeUnion/xud#1545 - let's handle this in the course of bringing connext to testnet |
Would you mind testing restore for lndbtc/lndltc again properly? @raladev This has to work flawlessly. |
* apply create/restore flow for simnet * enable xud-backup for simnet * remove --noseedbackup for lnds * remove admin.macaroon waiting * remove -m option to let background jobs respond to SIGINT Setting -m will let background jobs run in another process group which will ignore SIGINT. Removing -m will let the jobs run in the same process group. Ref. https://stackoverflow.com/questions/45106725/why-do-shells-ignore-sigint-and-sigquit-in-backgrounded-processes * add 5 seconds waiting before create/restore flow to prevent lnd unlock stuck * fix lndltc version missing * fix typo * extend lnd warn up waiting to 15 seconds * beautify starting... * restart lnds after successful xucli create * add syncing details to lnd status * reduce staring... waiting time to 5 seconds * add 5 seconds waiting before restarting lnds * change starting... to warming up... * move restarts after backup location setup & add xud restart * comment out xud restart * waiting for tls.cert * restart xud with 15 seconds delay * remove ltcd and raiden dirs * block restarting until xud is locked * auto unlock * refine lnd restarts * refine unlock * comment out lncli connect * adjust restart text * fix socket timeout when exec_run * adjust restart text * refine restarting text * refine auto-unlock with Ctrl-C and pre-check for xud lock status Co-authored-by: Yang Yang <[email protected]>
* try with lnd 0.10.0-beta * revert lndltc to 0.9.0-beta Co-authored-by: Yang Yang <[email protected]>
This reverts commit b29d140.
|
|
This reverts commit cac067c.
Adds connext and
Closes ExchangeUnion/xud#1457
Closes ExchangeUnion/xud-simnet#78
Closes #382
Closes #277
Closes #409
Closes #425