Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up/Down improvements #304

Closed
1 of 2 tasks
kilrau opened this issue Feb 21, 2020 · 6 comments · Fixed by #483
Closed
1 of 2 tasks

Up/Down improvements #304

kilrau opened this issue Feb 21, 2020 · 6 comments · Fixed by #483
Assignees
Labels
enhancement New feature or request P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Feb 21, 2020

  • when starting an environment and xud/lnd's are locked, automatically run unlock on start. If for some reason the user does not want to unlock, she can still CTRL+C. Rename Enter master xud password -> Enter xud master password.

                           .___           __  .__   
          ___  _____ __  __| _/     _____/  |_|  |  
          \  \/  /  |  \/ __ |    _/ ___\   __\  |  
           >    <|  |  / /_/ |    \  \___|  | |  |__
          /__/\_ \____/\____ |     \___  >__| |____/
                \/          \/         \/           
--------------------------------------------------------------

Enter xud master password: 
xud was unlocked succesfully
The following wallets were unlocked: BTC, LTC
testnet > 
  • down & stop should bring up: Are you sure to shutdown your xud environment (this will cancel all open orders)? [Y/n] .

After all containers are brought down, it should automatically exit xud ctl and remove the utils container:

testnet > down
Are you sure to shutdown your xud environment (this will cancel all open orders)? [Y/n] y
Stopping bitcoind ...
Stopping litecoind ...
Stopping geth ...
Stopping lndbtc ...
Stopping lndltc ...
Stopping raiden ...
Stopping xud ...
Removing bitcoind ...
Removing litecoind ...
Removing geth ...
Removing lndbtc ...
Removing lndltc ...
Removing raiden ...
Removing xud ...
Removing network testnet_default
Removing utils ...
kilrau@K-Yoga:~$ 
@kilrau kilrau added enhancement New feature or request P3 low priority labels Feb 21, 2020
@kilrau kilrau added P2 mid priority and removed P3 low priority labels Feb 21, 2020
@kilrau kilrau assigned engwarrior and unassigned engwarrior Feb 28, 2020
@kilrau
Copy link
Contributor Author

kilrau commented May 5, 2020

1/2 already done in #429, 2/2/ should be easy enough too.

@kilrau
Copy link
Contributor Author

kilrau commented May 26, 2020

Unfortunately we managed to break auto prompt unlock on start again, tested just now with latest xud-docker master on simnet:

Creating simnet_lndbtc_1...
Creating simnet_lndltc_1...
Creating simnet_connext_1...
Creating simnet_xud_1...

🏃 Warming up...


                           .___           __  .__   
          ___  _____ __  __| _/     _____/  |_|  |  
          \  \/  /  |  \/ __ |    _/ ___\   __\  |  
           >    <|  |  / /_/ |    \  \___|  | |  |__
          /__/\_ \____/\____ |     \___  >__| |____/
                \/          \/         \/           
--------------------------------------------------------------

simnet > getinfo
xud is locked, run 'xucli unlock', 'xucli create', or 'xucli restore' then try again

@reliveyy
Copy link
Collaborator

Unfortunately we managed to break auto prompt unlock on start again

I tried many times on master and I cannot reproduce it. I'll keep an eye on this missing pre-xudctl unlock problem.

@reliveyy
Copy link
Collaborator

@kilrau The text Enter master xud password is from xucli unlock command. I think a simple fix is modifying it on xud side.

BTW, if we still want to customize node cli text, I have two plans for it.

  1. Still run node CLI process but do text modification line by line on the output.
  2. Use node RPC protocol (gRPC, JSON-RPC) and write whatever text on the xud-docker side.

Do you remember we were going to customize xucli create output text but since it's from xud side then we leave it for now.

@kilrau
Copy link
Contributor Author

kilrau commented Jun 1, 2020

I tried many times on master and I cannot reproduce it. I'll keep an eye on this missing pre-xudctl unlock problem.

Sometimes didn't work for me in existing, locked environments. Will test again once #487 is in which is blocking testing this atm.

@kilrau
Copy link
Contributor Author

kilrau commented Jun 1, 2020

Tested, works. Marked it as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 mid priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants