Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connext on simnet #97

Merged
merged 14 commits into from
May 15, 2020
Merged

Connext on simnet #97

merged 14 commits into from
May 15, 2020

Conversation

kilrau
Copy link
Contributor

@kilrau kilrau commented May 6, 2020

Preview @ https://docs.exchangeunion.com/v/develop/

  • raiden -> connext
  • remove native simnet guide
  • docker install instructions simplification
  • add simnet "create" part, switch simnet status to "live"
  • ubuntu 18.04 -> 20.04
  • misc wording/order fixes

Depends on ExchangeUnion/xud-docker#429

@kilrau kilrau requested review from a user and peartobear May 6, 2020 17:18
@kilrau kilrau marked this pull request as ready for review May 6, 2020 17:19
@kilrau kilrau requested a review from sangaman May 6, 2020 17:22
@kilrau kilrau changed the title Update everything Connext on simnet May 6, 2020
@kilrau kilrau self-assigned this May 6, 2020
Copy link
Contributor

@sangaman sangaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things to note, I haven't tried the docker install steps in particular but I'm not sure they would work given the current situation with docker & 20.04.

BeastXUD.md Outdated
disco \
stable"
```
5. Install docker by running `sudo apt install docker.io`. If you are not using Ubuntu 20.04 LTS, follow the [official instructions](https://docs.docker.com/install/linux/docker-ce/ubuntu/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, and I have run into this locally since upgrading to 20.04, there is no ppa for docker in ubuntu 20.04 and the official install instructions don't support it. From the link here you'll see it's not included (yet):

To install Docker Engine, you need the 64-bit version of one of these Ubuntu versions:

Ubuntu Eoan 19.10
Ubuntu Bionic 18.04 (LTS)
Ubuntu Xenial 16.04 (LTS)

Either way, I think it might make sense not to specify exact ubuntu versions here (and a few lines above) since official support doesn't appear to be there and since versions will change over time.

Copy link
Contributor Author

@kilrau kilrau May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install docker by running sudo apt install docker.io

This installs the ubuntu-maintained docker version, relatively up-to-date (19.03.8 as of now) and I read about plans to keep it up-to-date. This is the only way to install docker properly on ubuntu 20.04 rn. I tested this on multiple machines and it's working fine.

The funny thing about the docker official instructions is, that they are wrong (e.g. ubuntu 19.10 is actually not supported, but 19.04 is, so you manually have to change their install script to get things using disco (19.04) to get docker working on 19.10. But since I don't really want to take care of fixing docker install instructions and things work out of the box on 20.04, that's what I want to recommend:

  • if you run ubuntu 20.04, our recommendation, install docker with sudo apt install docker.io
  • if you run something else, follow the instructions: https://docs.docker.com/install or figure out how to install docker yourself

Since this was not clear obviously - ideas how to express it better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks for the explanation. How about:

If you are using Ubuntu 20.04 LTS, install docker by running sudo apt install docker.io. Otherwise if you are using any version besides 20.04, follow the official instructions to install docker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx!


Private chains which are maintained by Exchange Union. We’ll automatically open channels to you and push over some coins, you’ll be trading against our bots and anyone else running simnet. It’s the perfect playground to see how things work and get familiar with `xucli` commands. It’s easy: run the launch script, wait for about 15 minutes and you are ready to go. **You want to start with this!**
Private chains which are maintained by Exchange Union. We’ll automatically open channels to you and push over some coins, you’ll be trading against our bots and anyone else running simnet. It’s the perfect playground to see how things work and get familiar with `xucli` commands. It’s easy: run the launch script, create the environment wait for about 15 minutes for your balance (`getbalance`) and you are ready to go. **You want to start with this!**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma after "create the environment"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

RaspiXUD.md Outdated
@@ -133,7 +127,7 @@ From here the light and full setup require different settings. Continue choosing

## Pi Light Setup

Important: to make sure we don't run out of RAM, we create a swap file (overflow RAM) of 2GB on the internal sd card:
If you are using a Pi model with 2GB of RAM or more, you can straigt continue [here](Market%20Maker%20Guide.md#the-setup). If you are using a Pi model with <2GB of RAM, we will have to catch a temporary RAM spike when creating the xud environment by creating a swap file (overflow RAM) of 2GB on the internal sd card:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straigt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@kilrau kilrau requested review from peartobear and sangaman May 7, 2020 16:28
Market Maker Guide.md Outdated Show resolved Hide resolved
@kilrau kilrau requested a review from a user May 8, 2020 08:28
@kilrau kilrau added P2 mid priority P3 low priority and removed P2 mid priority labels May 12, 2020
@kilrau kilrau dismissed stale reviews from sangaman and peartobear May 15, 2020 09:52

All fixed and blocking

@kilrau kilrau merged commit 8fc01a1 into master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants