Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust error message for openchannel command #1560

Closed
ghost opened this issue May 14, 2020 · 3 comments
Closed

Adjust error message for openchannel command #1560

ghost opened this issue May 14, 2020 · 3 comments
Assignees
@rsercano
Labels
bug Something isn't working logging Log messages and output P3 low priority

Comments

@ghost
Copy link

ghost commented May 14, 2020

Offshoot from: ExchangeUnion/xud-docker#429 (comment)

When the openchannel command fails for Connext it should not display nodePubKey in the error message.
@ghost ghost mentioned this issue May 14, 2020
Merged
@kilrau kilrau added bug Something isn't working logging Log messages and output P2 mid priority labels May 14, 2020
@sangaman
Copy link
Collaborator

Instead it should print the actual alias (nodePubKey).

I think this would be a slightly separate issue? Connext doesn't deal with nodepubkey or alias at all for opening a channel.

@kilrau
Copy link
Contributor

kilrau commented May 14, 2020

I think this would be a slightly separate issue? Connext doesn't deal with nodepubkey or alias at all for opening a channel.

True.. simply removing nodePubKey should do.

@kilrau kilrau added P3 low priority and removed P2 mid priority labels Jul 8, 2020
@kilrau kilrau assigned rsercano and unassigned sangaman Oct 19, 2020
@rsercano
Copy link
Collaborator

Is this already fixed within 704072e ? @sangaman @kilrau

@kilrau kilrau closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
bug Something isn't working logging Log messages and output P3 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sangaman @rsercano @kilrau