[Feature] Implement "Big Bags" #4548

Kinglykrab · 2024-11-22T04:24:16Z

Description

Implements bags up to 200 slots for ROF2 clients.

Disclaimer

Servers using older clients (pre-ROF2) will need to use the following query to limit all their bags to 10 bag slots so their servers still function properly.

UPDATE `items` SET `bagslots` = 10 WHERE `bagslots` > 10;

Type of change

Breaking change
This change requires a documentation update

Before and After Slot IDs

Testing

Clients tested: ROF2

Checklist

I have tested my changes
I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
I have made corresponding changes to the documentation (if applicable, if not delete this line)
I own the changes of my code and take responsibility for the potential issues that occur
I have tested the changes on a local database and updated version.h CURRENT_BINARY_DATABASE_VERSION to the new version.

Credits

Thanks to @catapultam-habeo and @SecretsOTheP for sharing their bag implementations and allowing me to finalize a version for EQEmulator as a whole.

crotonrz · 2024-11-22T04:52:04Z

Thousands of players who don't follow server code, just got a semi...and they don't yet know why.

* Fix a formatting bug with #mystats When using values larger than 1,000, we were calling commify on a string that already had commas. This resulted in the value 1005 looking like 1,,005. * Update mob.cpp --------- Co-authored-by: Alex King <[email protected]>

…4552)

… trading (#4553)

This adds a compile time concept to determine if from_chars has floating-point support and uses fallbacks if not. This is a C++17 feature but support for floats was only added to libstdc++ with GCC 11.1 and LLVM libc++ in 20.0 (unreleased).

This allows task elements to update in any zone when it has an invalid zone id <= 0. This has the same effect as leaving the zones field empty except "Unknown Zone" instead of "ALL" will be shown in task windows. Note that Titanium shows "ALL" for a zone id of 0 despite it being an invalid zone id. This could be manipulated server side to match newer clients but there isn't much benefit since any other invalid zone id below 0 can be used to do the same.

Previously level requirement was only being checked on the initial rank of an AA. If passed, bots would gain all ranks for that AA regardless of level, this will now check for the level requirement for each rank before granting the AA

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0. - [Commits](golang/crypto@v0.21.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [Cleanup] Convert Event Parses to Single Line * Push * Update spells.cpp * Update spells.cpp --------- Co-authored-by: Akkadius <[email protected]>

) * [Databuckets] Don't broadcast client-scoped updates * Remove temp feature flag * Remove distributed caching, only cache for character scoped data, simplify * Update bot.cpp * Cleanup * Update data_bucket.cpp * Cleanup * Cleanup * Remove BulkLoadEntities from LoadNPCTypes * Update data_bucket.cpp * Cleanup * More cleanup * More cleanup * BulkLoadEntities to BulkLoadEntitiesToCache * Add CanCache in DeleteData to gate an unnecessary call

* First pass to enable trader 'Find Trader' functionality * Move SendBulkTraders out of zoning routines and send as part of the opening of the bazaar search window. Add zone instance to SendBulkTraders to support multi-instanced bazaars.

* rules for enabling requiring custom files * shorten default * variable name * check account status for enforcing client key * rule for custom files admin level --------- Co-authored-by: Paul Johnson <[email protected]>

* [Bug Fix] Allow Items in ROF2 to Stack to 32,767 * Update rof2.cpp

* [Database] Change npc_types walkspeed to be of type float * Update database_update_manifest.cpp

Add Bazaar BulkSendTrader Limit

* [Zone] Implement zone player count sharding * Update client.cpp * Update database_instances.cpp * You must request a shard change from the zone you are currently in. * // zone sharding * You cannot request a shard change while in combat. * Query adjustment * Use safe coords * Changes * Fixes to instance query * Push * Push * Final push * Update client.cpp * Update eq_packet_structs.h * Remove pick menu * Comment * Update character_data_repository.h * Update zoning.cpp --------- Co-authored-by: Kinglykrab <[email protected]>

Memory leak repairs

* Update trader add/remove to limit for RoF2 Update trader add/remove to limit for RoF2 * Update for feedback --------- Co-authored-by: Mitch Freeman <[email protected]>

* basic evolving items framework created * Implement evolving tab in the inventory window * Implement experience and number of kills * Move zone evolving map to a evolvingitemsmanager class * rework gm commands * rework GetInventory * wip * wip loot testing * Fix Duplicate Message * reworked evolving item looting, swapping, etc * reworked const functions for evolving methods * Functioning Player Trade of evolving items test item_id is 89550 * First pass of Final Result link working * First pass of item upgrading when reaching 100% * Add strings and logic for displaying the evolving item xp transfer window in Corathus * Prototype of xp transfer window sending items * WIP for evolve xp transfer * WIP for evolve xp transfer. First tests passed * XP Transfer Cleanup * XP Transfer Cleanup * Add Rule for evolving items equip timer/ default is 30 secs * Add logging and player events Add logging and player events * Formatting * Database updates * Updates for linux build * Perl/Cleanup * Command cleanup * Lua * Added a crash condition check if final item id is blank or not found. * Review Changes Updates to resolve review comments and a rebase. * migrate to content_db for items_evolving_details migrate to content_db for items_evolving_details * Simplify, don't hit database unless evolving * Update 2025_01_19_items_evolving_details.sql * Update client.cpp * Update manifest with items_evolving_details * character_id vs char_id * Remove _Struct from structs * Remove license header in evolving.cpp * Move evolving constants from eq_constants.h to evolving.h since it is more specific * Update database_schema.h * General cleanup * Be more specific with `evolving_items` vs `evolving` --------- Co-authored-by: Kinglykrab <[email protected]> Co-authored-by: Akkadius <[email protected]>

* Add Alternate Bazaar Search This adds an alternate bazaar search allowing multinstance bazaar searching and traders above 600. Allows searches based on Bazaar Shard * Update worldserver.cpp --------- Co-authored-by: Mitch Freeman <[email protected]> Co-authored-by: Akkadius <[email protected]>

* [Feature] Add Support for Item Previews * Update client_packet.cpp

* Zone optimizations * More changes * More * Update entity.cpp * Beautiful * Amazing * Feature flag all logic * Broadcast to group * Update mob.cpp * Updates * Update client.cpp * Update client.cpp * Add rule Zone:EnableEntityClipping * Little bit of cleanup * Don't send update to self while in group * Remove visibility work and feature flags * Cleanup * Logging * Improve CheckSendBulkNpcPositions * No need to cast * Field cleanup * Build initial list on zone-in

* KSM work * Windows fixes * Add KSM logging, cleanup * Cleanup raycast logging

* [Databuckets] Add Account Scoped Databuckets * Add variation * Fix Lua after testing

* rebase\tidy up to address commends * I blame git for this one * last typo * spaces * formating fixes I think? * Repository fixes * Cleanup --------- Co-authored-by: Akkadius <[email protected]>

…to feature/big_bags

MortimerGreenwald · 2025-01-22T17:49:40Z

A couple of reports:

Also:
When opening multiple large-capacity bags and attempting to left-click items to move them to the bank bag, the following issues occur:
Approximately half of the bag slots disappear
The X button to close bags becomes non-functional
Items become invisible when attempting to move them with left-click (items still exist but cannot be seen)
Note: The bags function normally when only a few are opened.

Kinglykrab added 6 commits November 21, 2024 23:29

[Feature] Implement "Big Bags"

738a31d

Update worlddb.cpp

1da7901

Update shareddb.cpp

77de74a

Cleanup

95687b5

Cleanup

cd158aa

Add slot ID conversions

df746dd

Kinglykrab force-pushed the feature/big_bags branch from 6eebfc7 to df746dd Compare November 22, 2024 04:29

carolus21rex and others added 11 commits November 22, 2024 16:23

[Bug Fix] Fix for sending money via Parcel, then changing your mind (#…

a49d144

…4552)

[Bug Fix] Players could become flagged as a Trader when they were not…

7a841c1

… trading (#4553)

[Bug Fix] Fix Issue with Perl EVENT_PAYLOAD (#4545)

3158386

[Config] Fix World TCP Address Configuration Default (#4551)

630da0e

[Bug Fix] Fix Possible Item Loss in Trades (#4554)

9938755

[Rules] Add Rule to Disable NPCs Facing Target (#4543)

6bd758b

[Release] 22.60.0 (#4555)

3d7cf42

[Bug Fix] Fix EVENT_COMBAT on NPC Death (#4558)

fe9df46

Kinglykrab marked this pull request as ready for review December 3, 2024 01:49

nytmyr and others added 10 commits December 4, 2024 16:04

[Groups] Fix AmIMainAssist incorrectly checking for MainTankName (#4565)

5f0b999

[Bots] Fix AA ranks to account for level (#4567)

8e40e53

Previously level requirement was only being checked on the initial rank of an AA. If passed, bots would gain all ranks for that AA regardless of level, this will now check for the level requirement for each rank before granting the AA

[Cleanup] Convert Event Parses to Single Line (#4569)

5c6e7a8

* [Cleanup] Convert Event Parses to Single Line * Push * Update spells.cpp * Update spells.cpp --------- Co-authored-by: Akkadius <[email protected]>

[Cleanup] Remove Unused Group Methods (#4559)

0f164c4

[Commands] Add #find ldon_theme Subcommand (#4564)

3f3c0f2

[Rules] Add rules for requiring custom files from client (#4561)

3b779ef

* rules for enabling requiring custom files * shorten default * variable name * check account status for enforcing client key * rule for custom files admin level --------- Co-authored-by: Paul Johnson <[email protected]>

[Bug Fix] Allow Items in ROF2 to Stack to 32,767 (#4556)

e258aaa

* [Bug Fix] Allow Items in ROF2 to Stack to 32,767 * Update rof2.cpp

Akkadius and others added 27 commits January 7, 2025 14:46

[Database] Change npc_types walkspeed to be of type float (#4589)

03b30d5

* [Database] Change npc_types walkspeed to be of type float * Update database_update_manifest.cpp

[Fix] Repair a memory leak in #summonitem (#4591)

533dc99

[Fix] Add Bazaar BulkSendTrader Limit for RoF2 (#4590)

1568456

Add Bazaar BulkSendTrader Limit

[Fix] Update a few Bazaar RoF2 routines for memory leaks (#4592)

c2ebc25

Memory leak repairs

[Quest API] Add SetAAEXPPercentage to Perl/Lua (#4597)

035c519

[Fix] Update trader add/remove packets to limits for RoF2 (#4595)

d47bf68

* Update trader add/remove to limit for RoF2 Update trader add/remove to limit for RoF2 * Update for feedback --------- Co-authored-by: Mitch Freeman <[email protected]>

[Feature] Add Support for Item Previews (#4599)

75698a8

* [Feature] Add Support for Item Previews * Update client_packet.cpp

[Hotfix] Fix query error in character_evolving_items

1a27127

[Linux] Implement KSM Kernel Samepage Merging with Maps (#4601)

d13c725

* KSM work * Windows fixes * Add KSM logging, cleanup * Cleanup raycast logging

[Databuckets] Add Account Scoped Databuckets (#4603)

37ced4b

* [Databuckets] Add Account Scoped Databuckets * Add variation * Fix Lua after testing

[Hotfix] Update database version to match manifest

dba494c

[Hotfix] CLI help menu from parsing correctly in World

90c3739

[CLI] Add --skip-backup to world database:updates (#4605)

0acad18

[Feature] Implement Custom Pet Names (#4594)

31abaf8

* rebase\tidy up to address commends * I blame git for this one * last typo * spaces * formating fixes I think? * Repository fixes * Cleanup --------- Co-authored-by: Akkadius <[email protected]>

[Feature] Implement "Big Bags"

f30371a

Update worlddb.cpp

44f708a

Update shareddb.cpp

a2dba75

Cleanup

0e2c9c1

Cleanup

7ebd9b9

Add slot ID conversions

7fdb4f9

Update shareddb.cpp

4b63313

Update database_update_manifest.cpp

dc622b5

Merge branch 'feature/big_bags' of https://github.com/EQEmu/Server in…

e6f81a3

…to feature/big_bags

Kinglykrab closed this Jan 22, 2025

Kinglykrab deleted the feature/big_bags branch January 22, 2025 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Implement "Big Bags" #4548

[Feature] Implement "Big Bags" #4548

Kinglykrab commented Nov 22, 2024 •

edited

Loading

crotonrz commented Nov 22, 2024

MortimerGreenwald commented Jan 22, 2025

[Feature] Implement "Big Bags" #4548

[Feature] Implement "Big Bags" #4548

Conversation

Kinglykrab commented Nov 22, 2024 • edited Loading

Description

Disclaimer

Type of change

Before and After Slot IDs

Testing

Checklist

Credits

crotonrz commented Nov 22, 2024

MortimerGreenwald commented Jan 22, 2025

Kinglykrab commented Nov 22, 2024 •

edited

Loading