Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix] Allow Items in ROF2 to Stack to 32,767 #4556

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[Bug Fix] Allow Items in ROF2 to Stack to 32,767 #4556

merged 2 commits into from
Dec 12, 2024

Conversation

Kinglykrab
Copy link
Contributor

@Kinglykrab Kinglykrab commented Nov 26, 2024 •
edited
Loading

Description

  • ROF2 actually allows items to stack to 32,767 instead of just to 1,000

Type of change

  • New feature

Testing

image

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@crotonrz
Copy link

@Akkadius hit coder buttons and approve this! :)

@fryguy503
Copy link
Contributor

Curious, what happens to items when users switch between clients rof2->titanium

Akkadius
Akkadius reviewed Dec 12, 2024
View reviewed changes
@Akkadius Akkadius merged commit e258aaa into master Dec 12, 2024
2 checks passed
@Akkadius Akkadius deleted the bug_fix/rof2_stacksize branch December 12, 2024 22:39
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Dec 13, 2024
@Kinglykrab @MortimerGreenwald
[Bug Fix] Allow Items in ROF2 to Stack to 32,767 (EQEmu#4556)
c9422ae 
* [Bug Fix] Allow Items in ROF2 to Stack to 32,767

* Update rof2.cpp
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Dec 13, 2024
@Kinglykrab @MortimerGreenwald
[Bug Fix] Allow Items in ROF2 to Stack to 32,767 (EQEmu#4556)
283ec93 
* [Bug Fix] Allow Items in ROF2 to Stack to 32,767

* Update rof2.cpp
@Akkadius Akkadius mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kinglykrab @crotonrz @fryguy503 @Akkadius