Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Convert Event Parses to Single Line #4569

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[Cleanup] Convert Event Parses to Single Line #4569

merged 4 commits into from
Dec 12, 2024

Conversation

Kinglykrab
Copy link
Contributor

Description

  • This will allow Spire to properly parse these events, due to them being on multiple lines Spire was not parsing them so they did not show up in the events dropdown.

Type of change

  • Bug fix

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

@Akkadius Akkadius merged commit 5c6e7a8 into master Dec 12, 2024
2 checks passed
@Akkadius Akkadius deleted the cleanup/event_parse_single_line branch December 12, 2024 06:43
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Dec 13, 2024
@dependabot @Akkadius @MortimerGreenwald
Bump golang.org/x/crypto in /utils/scripts/build/should-release (EQEm…
612b03a 
…u#4570)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0.
- [Commits](golang/crypto@v0.21.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

[Rules] Add rules for requiring custom files from client (EQEmu#4561)

* rules for enabling requiring custom files

* shorten default

* variable name

* check account status for enforcing client key

* rule for custom files admin level

---------

[Commands] Add #find ldon_theme Subcommand (EQEmu#4564)

[Cleanup] Remove Unused Group Methods (EQEmu#4559)

[Feature] Enable bazaar window 'Find Trader' functionality (EQEmu#4560)

* First pass to enable trader 'Find Trader' functionality

* Move SendBulkTraders out of zoning routines and send as part of the opening of the bazaar search window.
Add zone instance to SendBulkTraders to support multi-instanced bazaars.

[Databuckets] Improved Reliability and Performance of Databuckets (EQEmu#4562)

* [Databuckets] Don't broadcast client-scoped updates

* Remove temp feature flag

* Remove distributed caching, only cache for character scoped data, simplify

* Update bot.cpp

* Cleanup

* Update data_bucket.cpp

* Cleanup

* Cleanup

* Remove BulkLoadEntities from LoadNPCTypes

* Update data_bucket.cpp

* Cleanup

* More cleanup

* More cleanup

* BulkLoadEntities to BulkLoadEntitiesToCache

* Add CanCache in DeleteData to gate an unnecessary call

[Cleanup] Convert Event Parses to Single Line (EQEmu#4569)

* [Cleanup] Convert Event Parses to Single Line

* Push

* Update spells.cpp

* Update spells.cpp

---------

Co-Authored-By: Paul Johnson <[email protected]>
Co-Authored-By: Akkadius <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Dec 13, 2024
@dependabot @MortimerGreenwald
Bump golang.org/x/crypto in /utils/scripts/build/should-release (EQEm…
70f0ee1 
…u#4570)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0.
- [Commits](golang/crypto@v0.21.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

[Rules] Add rules for requiring custom files from client (EQEmu#4561)

* rules for enabling requiring custom files

* shorten default

* variable name

* check account status for enforcing client key

* rule for custom files admin level

---------

[Commands] Add #find ldon_theme Subcommand (EQEmu#4564)

[Cleanup] Remove Unused Group Methods (EQEmu#4559)

[Feature] Enable bazaar window 'Find Trader' functionality (EQEmu#4560)

* First pass to enable trader 'Find Trader' functionality

* Move SendBulkTraders out of zoning routines and send as part of the opening of the bazaar search window.
Add zone instance to SendBulkTraders to support multi-instanced bazaars.

[Databuckets] Improved Reliability and Performance of Databuckets (EQEmu#4562)

* [Databuckets] Don't broadcast client-scoped updates

* Remove temp feature flag

* Remove distributed caching, only cache for character scoped data, simplify

* Update bot.cpp

* Cleanup

* Update data_bucket.cpp

* Cleanup

* Cleanup

* Remove BulkLoadEntities from LoadNPCTypes

* Update data_bucket.cpp

* Cleanup

* More cleanup

* More cleanup

* BulkLoadEntities to BulkLoadEntitiesToCache

* Add CanCache in DeleteData to gate an unnecessary call

[Cleanup] Convert Event Parses to Single Line (EQEmu#4569)

* [Cleanup] Convert Event Parses to Single Line

* Push

* Update spells.cpp

* Update spells.cpp

---------

Co-Authored-By: Paul Johnson <[email protected]>
Co-Authored-By: Akkadius <[email protected]>
Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Revert "Bump golang.org/x/crypto in /utils/scripts/build/should-release (EQEmu#4570)"

This reverts commit 612b03a.
@Akkadius Akkadius mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akkadius Akkadius Akkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kinglykrab @Akkadius