Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add Bazaar BulkSendTrader Limit for RoF2 #4590

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

neckkola
Copy link
Contributor

@neckkola neckkola commented Jan 8, 2025

Description

RoF2 has a client limit of 600 traders. Currently, this is not checked server side and therefore if there are more than 600 traders (reached with THJ large player base), the client would crash upon receiving the BulkSendTrader list packet.

This packet populates the bazaar search window dropdown list of traders and is required for the window to function.

With this fix, I have created a constant for RoF2 for this limitation allow for this to be easily modified as newer clients are added. This will allow the server operator to have more than 600 traders, and limit the packet to 600 max. The client allows for 'all traders' (the 600 limit) and 'local traders' (the players current zone). I have therefore created the packet to include all the traders from the players local zone and then augment to the 600 max with traders from outside the local zone. This will allow players to search 'up to' 600 traders, and always have access to the local traders (which on THJ is set to 200).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

This was tested with a trader table of 1000 traders, with 12 in instance 34 and the remaining 988 in instance 35. The client was able to login without crashing, zone without crashing and retrieve 12 traders with local trader searching, and 600 for all traders, which included the 12.

Clients tested:
RoF2

Checklist

  • I have tested my changes
  • I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context.
  • I own the changes of my code and take responsibility for the potential issues that occur

Add Bazaar BulkSendTrader Limit
@Akkadius Akkadius merged commit 1568456 into EQEmu:master Jan 8, 2025
1 check passed
Akkadius pushed a commit to The-Heroes-Journey-EQEMU/Server that referenced this pull request Jan 8, 2025
@Akkadius Akkadius mentioned this pull request Jan 27, 2025
MortimerGreenwald pushed a commit to MortimerGreenwald/Server that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants