[Feature] Enable bazaar window 'Find Trader' functionality #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neckkola
changed the title
…pening of the bazaar search window. Add zone instance to SendBulkTraders to support multi-instanced bazaars.
Akkadius
approved these changes
Dec 12, 2024
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Dec 13, 2024
…u#4570) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0. - [Commits](golang/crypto@v0.21.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> [Rules] Add rules for requiring custom files from client (EQEmu#4561) * rules for enabling requiring custom files * shorten default * variable name * check account status for enforcing client key * rule for custom files admin level --------- [Commands] Add #find ldon_theme Subcommand (EQEmu#4564) [Cleanup] Remove Unused Group Methods (EQEmu#4559) [Feature] Enable bazaar window 'Find Trader' functionality (EQEmu#4560) * First pass to enable trader 'Find Trader' functionality * Move SendBulkTraders out of zoning routines and send as part of the opening of the bazaar search window. Add zone instance to SendBulkTraders to support multi-instanced bazaars. [Databuckets] Improved Reliability and Performance of Databuckets (EQEmu#4562) * [Databuckets] Don't broadcast client-scoped updates * Remove temp feature flag * Remove distributed caching, only cache for character scoped data, simplify * Update bot.cpp * Cleanup * Update data_bucket.cpp * Cleanup * Cleanup * Remove BulkLoadEntities from LoadNPCTypes * Update data_bucket.cpp * Cleanup * More cleanup * More cleanup * BulkLoadEntities to BulkLoadEntitiesToCache * Add CanCache in DeleteData to gate an unnecessary call [Cleanup] Convert Event Parses to Single Line (EQEmu#4569) * [Cleanup] Convert Event Parses to Single Line * Push * Update spells.cpp * Update spells.cpp --------- Co-Authored-By: Paul Johnson <[email protected]> Co-Authored-By: Akkadius <[email protected]> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
MortimerGreenwald
pushed a commit
to MortimerGreenwald/Server
that referenced
this pull request
Dec 13, 2024
…u#4570) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.21.0 to 0.31.0. - [Commits](golang/crypto@v0.21.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> [Rules] Add rules for requiring custom files from client (EQEmu#4561) * rules for enabling requiring custom files * shorten default * variable name * check account status for enforcing client key * rule for custom files admin level --------- [Commands] Add #find ldon_theme Subcommand (EQEmu#4564) [Cleanup] Remove Unused Group Methods (EQEmu#4559) [Feature] Enable bazaar window 'Find Trader' functionality (EQEmu#4560) * First pass to enable trader 'Find Trader' functionality * Move SendBulkTraders out of zoning routines and send as part of the opening of the bazaar search window. Add zone instance to SendBulkTraders to support multi-instanced bazaars. [Databuckets] Improved Reliability and Performance of Databuckets (EQEmu#4562) * [Databuckets] Don't broadcast client-scoped updates * Remove temp feature flag * Remove distributed caching, only cache for character scoped data, simplify * Update bot.cpp * Cleanup * Update data_bucket.cpp * Cleanup * Cleanup * Remove BulkLoadEntities from LoadNPCTypes * Update data_bucket.cpp * Cleanup * More cleanup * More cleanup * BulkLoadEntities to BulkLoadEntitiesToCache * Add CanCache in DeleteData to gate an unnecessary call [Cleanup] Convert Event Parses to Single Line (EQEmu#4569) * [Cleanup] Convert Event Parses to Single Line * Push * Update spells.cpp * Update spells.cpp --------- Co-Authored-By: Paul Johnson <[email protected]> Co-Authored-By: Akkadius <[email protected]> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Revert "Bump golang.org/x/crypto in /utils/scripts/build/should-release (EQEmu#4570)" This reverts commit 612b03a.
Merged
joligario
added a commit
to ProjectEQ/peqphpeditor
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the 'Find Trader' button on the Bazaar search window. Tested against multi-instanced bazaars as well. Also updated the 'local/all' trader functions.
Update: 2024-12-03
Decided to move the SendBulkTraders out of the zoning routines to reduce zone in traffic. Instead moved to when the /bazaar window is first opened using a specific action type. I had done this with the buyer functionality was added and it has worked well. This will save (78 * num_traders)bytes from being sent on each zone, for each client.
Also updated the SendBulkTraders routine to be instance aware. I had missed that previously.
Type of change
Testing
https://www.youtube.com/watch?v=gwMwxlvyzek
Clients tested:
RoF2
Checklist