Conversation
📝 WalkthroughWalkthroughUpdates to compiled platform requirements and core requirement patch: added comfy-aimdo and comfy-kitchen, bumped multiple comfyui workflow template package versions, updated ComfyUI version in package.json, and removed comfyui-frontend-package from core requirements. Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c42f672b71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR bumps ComfyUI core from v0.11.1 to v0.12.1 and regenerates compiled Python requirements for all supported platforms (macOS, Windows CPU/NVIDIA/AMD). The update includes a new dependency (comfy-aimdo) and updated versions of workflow template packages.
Changes:
- Updated ComfyUI version in package.json from 0.11.1 to 0.12.1
- Updated core requirements patch to reflect new workflow-templates version (0.8.31)
- Regenerated compiled requirements for all platforms with updated dependency versions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumped ComfyUI version from 0.11.1 to 0.12.1 |
| scripts/core-requirements.patch | Updated workflow-templates version from 0.8.27 to 0.8.31 |
| assets/requirements/windows_nvidia.compiled | Added comfy-aimdo dependency and updated workflow-templates packages |
| assets/requirements/windows_cpu.compiled | Added comfy-aimdo dependency and updated workflow-templates packages |
| assets/requirements/windows_amd.compiled | Added comfy-aimdo dependency and updated workflow-templates packages |
| assets/requirements/macos.compiled | Added comfy-aimdo dependency, updated workflow-templates packages, torchaudio at 2.9.1 vs torch at 2.10.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
assets/requirements/macos.compiled (2)
291-305:⚠️ Potential issue | 🟠 MajorFix torch/torchaudio version mismatch on macOS.
The macos.compiled file pins torch to 2.10.0 but torchaudio to 2.9.1. Per PyTorch documentation, torch and torchaudio binaries must be from the same release and cannot be mixed—this combination will cause ABI/runtime issues. Note that windows_cpu.compiled and windows_nvidia.compiled correctly align both to matching versions (2.10.0), so only the macOS file requires regeneration.
Fix (regenerate macos.compiled with aligned versions)
-torchaudio==2.9.1 +torchaudio==2.10.0
52-79:⚠️ Potential issue | 🟠 MajorFix torch/torchaudio version mismatch on macOS.
PyTorch 2.10.0 requires torchaudio 2.10.0 (currently pinned to 2.9.1). This pairing is binary-incompatible and will cause runtime failures. Update
macos.compiledto use torchaudio==2.10.0 to match torch==2.10.0 (line 291 and 301).
## Summary - bump desktop app version to 0.8.1 DO NOT MERGE UNTIL THESE TWO PRS ARE MERGED 1. #1581 2. #1583 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Patch version update (0.8.1). <!-- end of auto-generated comment: release notes by coderabbit.ai --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1584-Bump-desktop-version-to-0-8-1-2fc6d73d365081ae830dd16019dd7479) by [Unito](https://www.unito.io)
Summary
Summary by CodeRabbit
┆Issue is synchronized with this Notion page by Unito