Warn about outdated NVIDIA drivers during fresh install

[benceruleanlu]

Summary

• show the NVIDIA driver warning immediately after install options are chosen
• reuse the same warning logic for updatePackages with the selected device

The bug was that this wasn't shown early enough in the install process that new users who do not have the latest NVIDIA driver for pytorch 2.10 is that they would crash during install without a good error code.

Summary by CodeRabbit

• Refactor
  • Optimized internal device handling in the installation management system for improved code maintainability and clarity.

┆Issue is synchronized with this Notion page by Unito

[coderabbitai]

📝 Walkthrough

Walkthrough

The warnIfNvidiaDriverTooOld method in InstallationManager was refactored to accept a device parameter directly instead of a ComfyInstallation object. Call sites were updated to pass the selected device value, simplifying the method's dependency on the installation object structure.

Changes

Cohort / File(s)	Summary
Nvidia Driver Warning Refactor src/install/installationManager.ts	Updated warnIfNvidiaDriverTooOld method signature to accept device parameter instead of ComfyInstallation object. Call sites in freshInstall and updatePackages modified to pass the device directly. Behavior remains gated by Windows platform and 'nvidia' device value.

Poem

A rabbit hops through code so neat, 🐰
Passing devices, sleek and sweet,
No more objects, just what's true,
Parameters refined and new! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: refactoring warnIfNvidiaDriverTooOld to show the warning during fresh install by accepting a device parameter instead of installation object.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch warn-nvidia-driver-early

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR improves the user experience by warning users about outdated NVIDIA drivers earlier in the installation process, right after they select their installation options. The change also refactors the warning method to accept a device parameter instead of the full installation object, making it reusable in multiple contexts.

Changes:

• Added early NVIDIA driver warning call immediately after installation options are selected
• Refactored warnIfNvidiaDriverTooOld to accept device parameter instead of installation object
• Updated the method call in updatePackages to pass the device from the virtual environment

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.