Conversation
📝 WalkthroughWalkthroughThis PR updates two dependency configurations: downgrades torchaudio from 2.10.0 to 2.9.1 in the macOS compiled requirements file, and bumps the comfyUI dependency from 0.12.1 to 0.12.2 in package.json. Both are version adjustments in configuration files. Changes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9e362657e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the embedded ComfyUI core version and refreshes the macOS compiled Python requirements to match the new core.
Changes:
- Bump
config.comfyUI.versioninpackage.jsonfrom0.12.1to0.12.2. - Regenerate
assets/requirements/macos.compiled, including a change oftorchaudiofrom2.10.0to2.9.1while leavingtorchat2.10.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the ComfyUI core version configuration to 0.12.2 to track the new upstream release. |
| assets/requirements/macos.compiled | Refreshes pinned macOS dependencies for the updated core, including a downgrade of torchaudio that now mismatches the torch version and the other platform requirement sets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/requirements/macos.compiled (1)
291-305:⚠️ Potential issue | 🟠 Majortorch and torchaudio version mismatch requires fix.
torch==2.10.0is incompatible withtorchaudio==2.9.1. Official PyTorch binaries are compiled against specific version pairs. Upgrade torchaudio to2.10.0to match torch.Fix
-torchaudio==2.9.1 +torchaudio==2.10.0
## Summary - Bump desktop version in package.json to 0.8.2 Merge after: - #1586 ## Testing - `yarn format` - `yarn lint` - `yarn typecheck` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1587-Bump-desktop-version-to-0-8-2-2fd6d73d365081ceb496d39272e14450) by [Unito](https://www.unito.io) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Version bumped to 0.8.2 <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
Testing
yarn formatyarn lintyarn typecheckSummary by CodeRabbit
┆Issue is synchronized with this Notion page by Unito