Conversation
📝 WalkthroughWalkthroughThis PR updates pinned versions for several comfyUI-related packages across platform-specific compiled requirements and bumps the comfyUI frontend version in package.json; no code-level API, control flow, or exported/public signatures were changed. Changes
Possibly related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5d2989992
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "comfyUI": { | ||
| "version": "0.12.3", | ||
| "version": "0.13.0", |
There was a problem hiding this comment.
Update bundled frontend version with ComfyUI upgrade
Bumping config.comfyUI.version to 0.13.0 without also bumping config.frontend.version leaves the app downloading frontend 1.37.11 (scripts/downloadFrontend.js reads this config) while the new core requirements patch shows ComfyUI now expects comfyui-frontend-package==1.38.13 (scripts/core-requirements.patch). Since this repo removes that package from pip requirements, installer checks no longer enforce the match, so the desktop can ship a backend/frontend version pair with known compatibility drift and runtime UI/API breakage.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Bumps the bundled ComfyUI core version to v0.13.0 and updates the pinned Python dependency sets used to build the desktop app across macOS and Windows targets.
Changes:
- Update
config.comfyUI.versionto0.13.0. - Refresh
scripts/core-requirements.patchto match ComfyUIv0.13.0upstreamrequirements.txt(frontend package removal + updated context versions). - Regenerate compiled Python requirements for macOS and Windows (CPU/NVIDIA/AMD).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/core-requirements.patch | Updates the patch used to modify upstream ComfyUI requirements.txt for desktop packaging. |
| package.json | Bumps ComfyUI core version configured for asset download/build. |
| assets/requirements/windows_nvidia.compiled | Updates pinned dependency set for Windows NVIDIA builds. |
| assets/requirements/windows_cpu.compiled | Updates pinned dependency set for Windows CPU builds. |
| assets/requirements/windows_amd.compiled | Updates pinned dependency set for Windows AMD builds. |
| assets/requirements/macos.compiled | Updates pinned dependency set for macOS builds (including Torch/TorchAudio pins). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "version": "1.37.11", | ||
| "optionalBranch": "" | ||
| }, | ||
| "comfyUI": { | ||
| "version": "0.12.3", | ||
| "version": "0.13.0", | ||
| "optionalBranch": "" |
There was a problem hiding this comment.
config.frontend.version is still 1.37.11, but the updated ComfyUI requirements context (and core-requirements.patch) indicates ComfyUI v0.13.0 expects comfyui-frontend-package==1.38.13. Unless this project intentionally decouples frontend/core versions, bump the frontend version in package.json to match to avoid runtime incompatibilities between the downloaded frontend and the ComfyUI backend.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Summary
config.comfyUI.versionto0.13.0scripts/core-requirements.patchto match ComfyUIv0.13.0requirements.txtSummary by CodeRabbit
┆Issue is synchronized with this Notion page by Unito