Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis PR updates version pins for multiple comfyui-workflow-templates packages across platform compiled requirements, bumps ComfyUI in Changes
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the embedded ComfyUI version used by the Electron app and refreshes the pinned Python dependency lockfiles to align with ComfyUI v0.14.1 requirements.
Changes:
- Bump
config.comfyUI.versionto0.14.1. - Update the core requirements patch to match ComfyUI v0.14.1
requirements.txt. - Regenerate per-platform compiled requirement lockfiles (Windows AMD/CPU/NVIDIA + macOS).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/core-requirements.patch | Updates the patch applied to ComfyUI core requirements.txt for v0.14.1. |
| package.json | Bumps the ComfyUI tag/version used when fetching ComfyUI assets. |
| assets/requirements/windows_nvidia.compiled | Refreshes Windows NVIDIA compiled Python requirements. |
| assets/requirements/windows_cpu.compiled | Refreshes Windows CPU compiled Python requirements. |
| assets/requirements/windows_amd.compiled | Refreshes Windows AMD compiled Python requirements. |
| assets/requirements/macos.compiled | Refreshes macOS compiled Python requirements (includes a Torch/Torchaudio version change). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
assets/requirements/macos.compiled
Outdated
| # torchvision | ||
| # from https://pypi.org/simple | ||
| torchaudio==2.10.0 | ||
| torchaudio==2.9.1 |
There was a problem hiding this comment.
In the macOS compiled requirements, torchaudio==2.9.1 is pinned alongside torch==2.10.0 (and torchvision==0.25.0). Torchaudio is typically tied to the same Torch release, and this mismatch is likely to cause install or runtime ABI/import errors on macOS. Please re-run the uv pip compile step (or adjust overrides) so torchaudio matches the torch version (or vice versa) for the macOS target.
| torchaudio==2.9.1 | |
| torchaudio==2.10.0 |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/requirements/macos.compiled (1)
291-305:⚠️ Potential issue | 🟠 Major
torchaudio==2.9.1is incompatible withtorch==2.10.0on macOS.PyTorch's official documentation states that "TorchAudio and PyTorch from different releases cannot be used together." Importing
torchaudioagainst a mismatchedtorchversion causes eitherImportErrorat runtime or silent failures in audio operations.The macOS compiled requirements currently pin
torchaudio==2.9.1while all other platforms (Windows CPU, NVIDIA, AMD) use matchingtorchandtorchaudioversions—both at 2.10.0. The mismatch appears to result from the platform resolver (aarch64-apple-darwin) selecting a different version during compilation, not from explicit version pinning inassets/override.txt(which only lists package names without version constraints).Update macOS to use
torchaudio==2.10.0to matchtorch==2.10.0, or document the platform-specific constraint if one exists.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@assets/requirements/macos.compiled` around lines 291 - 305, The macOS compiled requirements pin "torchaudio==2.9.1" which is incompatible with the pinned "torch==2.10.0"; update the macOS requirements to pin "torchaudio==2.10.0" so torchaudio and torch match (replace the torchaudio==2.9.1 entry with torchaudio==2.10.0), or if there is a platform-specific constraint, add a clear comment documenting why the mismatch must remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@assets/requirements/macos.compiled`:
- Around line 291-305: The macOS compiled requirements pin "torchaudio==2.9.1"
which is incompatible with the pinned "torch==2.10.0"; update the macOS
requirements to pin "torchaudio==2.10.0" so torchaudio and torch match (replace
the torchaudio==2.9.1 entry with torchaudio==2.10.0), or if there is a
platform-specific constraint, add a clear comment documenting why the mismatch
must remain.
Summary
config.comfyUI.versionto0.14.1scripts/core-requirements.patchto match ComfyUIv0.14.1requirements.txttorchaudio==2.10.0Testing
yarn formatyarn lintyarn typecheckSummary by CodeRabbit
Updates
Chores