fix: export asyncAggregateWithRandomness through napi binding

[nazarhussain]

Summary

asyncAggregateWithRandomness was declared as a pub fn in bindings/napi/blst.zig and re-exported from bindings/src/blst.js, but at runtime the JS-side binding was undefined. This PR rewrites the function to use the zapi DSL so it is actually registered as a JS export.

Root cause

zapi's exportModule auto-registration (export_module.zig, wrap_function.zig:isDslOrOptionalDsl) only picks up a pub fn when all of its parameters are DSL types (napi.Value, DSL wrappers like js.Array, or class types). The previous signature

pub fn asyncAggregateWithRandomness(env: napi.Env, cb: napi.CallbackInfo(1)) !napi.Value

uses raw NAPI types, so the function was silently skipped at registration. Because Zig is lazy about analyzing unreferenced functions, this also hid several internal bugs in the body that would otherwise have failed to compile.

Test plan

• pnpm test
• zig build build-lib:bindings -Doptimize=ReleaseSafe builds cleanly.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where asyncAggregateWithRandomness was not correctly exposed to the JavaScript environment due to signature mismatches with the zapi auto-registration requirements. By refactoring the function to adhere to the zapi DSL, the binding is now properly registered and functional. Additionally, the internal data handling was updated to improve type safety and robustness.

Highlights

• NAPI Binding Fix: Rewrote the asyncAggregateWithRandomness function to use the zapi DSL, ensuring it is correctly registered as a JS export.
• Type Safety Improvements: Updated internal data structures to use NativePublicKey and NativeSignature types for better consistency and compatibility with the NAPI layer.
• Testing: Added comprehensive test coverage for asyncAggregateWithRandomness, including validation of promise resolution, error handling, and concurrent execution.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the asyncAggregateWithRandomness function within the Zig NAPI bindings, refactoring the implementation to use js.Array and js.convertReturn while updating internal structures to use native public key and signature types. Comprehensive TypeScript tests were also added to verify the new asynchronous functionality. Review feedback identifies several violations of the repository style guide, specifically regarding the use of abbreviated variable names like stat, the use of underscores in function names, and the requirement to include assertions for all function arguments to maintain the necessary assertion density.

[gemini-code-assist]

The variable name stat is an abbreviation of status, which violates the repository style guide (Rule 221). Additionally, the function name asyncAggRand_complete uses an underscore, violating the camelCase requirement for function names (Rule 216). Finally, per Rule 51, function arguments should be asserted to ensure they are valid before use.

fn asyncAggRand_complete(env: napi.Env, status: napi.status.Status, data: *AsyncAggRandData) void {
    std.debug.assert(env.env != null);
    std.debug.assert(data.work != null);
    defer {

References

1. Do not abbreviate variable names. ^(link)
2. Use camelCase for function names. ^(link)
3. Assert all function arguments and return values. The assertion density of the code must average a minimum of two assertions per function. ^(link)

[gemini-code-assist]

The variable name stat is an abbreviation of status (Rule 221). Please also add assertions for the function arguments to comply with the repository's assertion density requirements (Rule 51).

fn settle(env: napi.Env, status: napi.status.Status, data: *AsyncAggRandData) !void {
    std.debug.assert(env.env != null);
    std.debug.assert(data.pks.ptr != null);
    if (status != .ok) {

References

1. Do not abbreviate variable names. ^(link)
2. Assert all function arguments and return values. ^(link)

[gemini-code-assist]

Per Rule 51 of the repository style guide, all function arguments must be asserted. Please add an assertion for the sets argument.

pub fn asyncAggregateWithRandomness(sets: js.Array) !js.Value {
    std.debug.assert(sets.val != null);
    const n = try sets.length();

References

1. Assert all function arguments and return values. ^(link)

[spiral-ladder]

LGTM, gemini reviews look pretty pedantic to me