fix: param order in BeaconBlockBody

[spiral-ladder]

extracted from #347

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a mismatch in the parameter ordering for the BeaconBlockBody type. By correcting the sequence of arguments, the code now aligns with the required structure, ensuring proper type resolution and consistency across the state transition utility.

Highlights

• Parameter Order Correction: Updated the parameter order in the BeaconBlockBody type definition within the isMergeTransitionBlock function to match the expected signature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the isMergeTransitionBlock function in src/state_transition/utils/execution.zig to swap the order of the fork and block_type parameters within the BeaconBlockBody type declaration. A review comment identifies a violation of the repository's style guide regarding assertion density and suggests adding specific assertions to verify the body matches the expected block_type and fork to improve code safety.

[gemini-code-assist]

The function isMergeTransitionBlock currently lacks assertions. According to the repository style guide (lines 51-55), every function should have an average of at least two assertions to detect programmer errors and document invariants. Adding assertions to verify that the body matches the expected block_type and fork helps satisfy this requirement and improves code safety.

    body: *const BeaconBlockBody(block_type, fork),
) bool {
    std.debug.assert(body.block_type == block_type);
    std.debug.assert(body.fork_seq == fork);

References

1. Assert all function arguments and return values, pre/postconditions and invariants. The assertion density of the code must average a minimum of two assertions per function. ^(link)