feat: migrate blst,pubkeys to use zapi js dsl

[nazarhussain]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request migrates the blst and pubkeys modules to the zapi JavaScript DSL. This transition significantly reduces the amount of manual NAPI boilerplate code required for native bindings, enhances maintainability, and improves the overall structure of the interface between Zig and JavaScript. The changes primarily involve replacing manual NAPI callback handling with the DSL's declarative approach, simplifying memory management, and updating function signatures to align with the new DSL patterns.

Highlights

• Migration to zapi JS DSL: Migrated blst and pubkeys modules to utilize the zapi JavaScript DSL, simplifying native bindings and improving type safety.
• Code Cleanup and Refactoring: Removed manual NAPI reference management and boilerplate registration code in favor of the DSL's automatic class and function handling.
• API Adjustments: Updated several public functions to use the new DSL-based types, including verify, aggregateVerify, and fastAggregateVerify, and adjusted pubkeys.size to be a function call.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the NAPI bindings for BLS operations and public key management to use the zapi library, replacing manual NAPI calls with higher-level abstractions and updating function signatures to use js types. Review feedback identifies an opportunity to improve buffer size consistency in hex parsing and points out violations of the 100-column line length limit specified in the style guide.

[gemini-code-assist]

The buffer size for hex_buf is inconsistent with the other fromHex methods in this file. While + 3 is not incorrect, for consistency with PublicKey.fromHex and Signature.fromHex which use * 2 + 2, you could reduce the size here. A size of NativeSecretKey.serialize_size * 2 + 2 should be sufficient to hold a hex string with a "0x" prefix.

        var hex_buf: [NativeSecretKey.serialize_size * 2 + 2]u8 = undefined;

References

1. The style guide emphasizes symmetry and making related code line up to make it easier to parse and check (lines 239-245). While this rule is about variable names, the principle of consistency for similar operations applies here to buffer sizes. ^(link)

[gemini-code-assist]

These lines exceed the 100-column limit specified in the style guide (line 400). You can format them across multiple lines for better readability and to adhere to the style guide.

    const pk_value = napi.Value{
        .env = env.env,
        .value = js.convertReturn(PublicKey, .{ .raw = result_pk }, env.env),
    };
    const sig_value = napi.Value{
        .env = env.env,
        .value = js.convertReturn(Signature, .{ .raw = result_sig }, env.env),
    };

References

1. Hard limit all line lengths, without exception, to at most 100 columns for a good typographic "measure". Use it up. Never go beyond. Nothing should be hidden by a horizontal scrollbar. To wrap a function signature, call or data structure, add a trailing comma, close your eyes and let zig fmt do the rest. ^(link)