This repository was archived by the owner on May 22, 2023. It is now read-only.
Feature/update to polkadot v0 9 0 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade test runner to use latest libp2p * Update test-utils/test-runner/Cargo.toml Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * Update Cargo.lock Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
* upgrade pallet atomic swap * fix doc
* Change companion check order Apparently if the pr isn't approved it counts as not mergable. However, this is rahter confusing. To fix this, we just change the order. * Move exit
* WIP convert sudo pallet to attribute macros * Fix up tests and migrate mock * Fix up genesis build * Migrate doc comment example * Update frame/sudo/src/lib.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Update frame/sudo/src/lib.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Update frame/sudo/src/lib.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Update frame/sudo/src/lib.rs Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> * Allow unused metadata call_functions Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
…ytech#8435) * Reservable, Transferrable Fungible(s), plus adapters. * Repot into new dir * Imbalances for Fungibles * Repot and balanced fungible. * Clean up names and bridge-over Imbalanced. * Repot frame_support::trait. Finally. * Make build. * Docs * Good errors * Fix tests. Implement fungible::Inspect for Balances. * Implement additional traits for Balances. * Revert UI test "fixes" * Fix UI error * Fix UI test * Fixes * Update lock * Grumbles * Grumbles * Fixes Co-authored-by: Bastian Köcher <info@kchr.de>
* Use `async_trait` in sc-consensus-slots This makes the code a little bit easier to read and also expresses that there can always only be one call at a time to `on_slot`. * slots: remove mutex around BlockImport in SlotWorker Co-authored-by: André Silva <andrerfosilva@gmail.com>
…h#8458) * [pallet-staking] Refund unused weight for `payout_stakers` fixes paritytech#8428 * Use periods in comments * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs * Address Shawn's Feedback * Assert monotomic weights && improve test note * Remove stray new line * debug_assert payout_count <= max * Only track payouts to nominators; not validators * Trivial comment update Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
…#8447) * make types within `generate_solution_type` macro explicit Closes paritytech#8444. Just changes the parsing logic for that macro; does not change any emitted code. The associated types associated with the macro now require explicit, keyword-style declaration. **Old**: ```rust sp_npos_elections::generate_solution_type!( #[compact] pub struct TestCompact::<VoterIndex, TargetIndex, PerU16>(16) ); ``` **New**: ```rust sp_npos_elections::generate_solution_type!( #[compact] pub struct TestCompact::<VoterIndex = VoterIndex, CandidateIndex = TargetIndex, Accuracy = PerU16>(16) ); ``` * un-ignore doc-tests * use new form in bin/node/runtime/ * rename CandidateIndex -> TargetIndex * add tests demonstrating some potential compile failures
* Reservable, Transferrable Fungible(s), plus adapters. * Repot into new dir * Imbalances for Fungibles * Repot and balanced fungible. * Clean up names and bridge-over Imbalanced. * Repot frame_support::trait. Finally. * Make build. * Docs * Good errors * Fix tests. Implement fungible::Inspect for Balances. * Implement additional traits for Balances. * Revert UI test "fixes" * Fix UI error * Fix UI test * More work on fungibles * Fixes * More work. * Update lock * Make fungible::reserved work for Balances * Introduce Freezer to Assets, ready for a reserve & locks pallet. Some renaming/refactoring. * Cleanup errors * Imbalances working with Assets * Test for freezer. * Grumbles * Grumbles * Fixes * Extra "side-car" data for a user's asset balance. * Fix * Fix test * Fixes * Line lengths * Comments * Update frame/assets/src/tests.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/support/src/traits/tokens/fungibles.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/assets/src/lib.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Update frame/support/src/traits/tokens/fungible.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> * Introduce `transfer_reserved` * Rename fungible Reserve -> Hold, add flag structs * Avoid the `melted` API - its too complex and gives little help * Repot Assets pallet Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
* Bring back the on_finalize weighg of stakin. * Better logs * Also make a few things pub * Fix build * Add assertions * Add test. * remove dbg * Update frame/election-provider-multi-phase/src/unsigned.rs * Update frame/staking/src/tests.rs * Fix * Fix * Update frame/election-provider-multi-phase/src/unsigned.rs
* Combine SnapshotConfig string fields name and directory into single PathBuf field named path * Update Cargo.lock * fix test build failure
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
* Prepare UI tests for Rust 1.51 & new CI image * another stderr to be fixed Co-authored-by: Denis P <denis.pisarev@parity.io>
* Add Social Network * Remove TNET * Update ss58-registry.json * Update ss58-registry.json * Update ss58-registry.json * Add back comment Co-authored-by: everhusk <sanghera@everhusk.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Github Actions <action@github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
This is not really required and having a special `test-helpers` feature is a bad idea anyway.
* Make grandpa work * Introduce `SharedData` * Add test and fix bugs * Switch to `SharedData` * Make grandpa tests working * More Babe work * Make it async * Fix fix * Use `async_trait` in sc-consensus-slots This makes the code a little bit easier to read and also expresses that there can always only be one call at a time to `on_slot`. * Make grandpa tests compile * More Babe tests work * Fix network test * Start fixing service test * Finish service-test * Fix sc-consensus-aura * Fix fix fix * More fixes * Make everything compile *yeah* * Fix build when we have Rust 1.51 * Update client/consensus/common/src/shared_data.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/common/src/shared_data.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/common/src/shared_data.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/common/src/shared_data.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/common/src/shared_data.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/babe/src/tests.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Update client/consensus/babe/src/tests.rs Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> * Fix warning Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
* helper macro to create storage types on the fly * Update frame/support/src/lib.rs Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> * update lock * fix test; * Fix line width Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
* client: rename variables * client: fix justifications migration * client: fix compilation
* Duplicate logging to stdout * Update client/tracing/src/logging/event_format.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
* tmp add upgrade file * Migrate pallet-indices to `pallet!` * Delete temp upgrade file * Fix some migration errors * Fix some warnings * Add serde bound, explicit balance type * Module -> Pallet
* Fixed sync missing some block announcements * Apply suggestions from code review Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
…aritytech#8392) * grandpa: always store justification for best finalized block * grandpa-warp-sync: add latest justification when finished proving * grandpa-warp-sync: change logic for sending best justification when finished * grandpa: test storing best justification * grandpa: reorder variants in WarpSyncFinished
* Introduce OnSetCode type into system config trait. * Docs. * Fixes * Fixes
* bounded treasury approvals * update benchmarks * update configs * cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_treasury --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/treasury/src/weights.rs --template=./.maintain/frame-weight-template.hbs * fix weight param Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
* Upgrade `cargo_metadata` to 0.13.1 * Update utils/wasm-builder/src/wasm_project.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
…ch#8675) * Introduce macro for building Contains impl based on a match * Fixes
Link was a dead-end
* client/network: support sending multiple justifications * network: flag support for multiple justifications in protobuf request * Update client/network/src/protocol.rs Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com> * network: update comment on protobuf field Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
…et (paritytech#8585) * grandpa: use new latest stored justification in prove_finality * grandpa: include end in range in FinalityProof::unknown_headers * grandpa: typo in comment * grandpa: remove ProvableJustification * grandpa: revert unnecessary changes * grandpa: extend AuthoritySetChangeId and cleanup get_set_id * grandpa: move check_finality_proof to the test module * grandpa: warn on missing authority set changes data * grandpa: add missing use statement * grandpa: simplify finality_proof tests * grandpa: additional tests for finality_proof Co-authored-by: André Silva <andrerfosilva@gmail.com>
…ytech#8691) * Remove unneeded `Ord` bound from All * Fixes * Contains supports tuples
* Use as_deref instead of .map in Node::client_version * Fix reliance on non-empty NodeInfo::endpoints
…:paritytech/substrate into feature/update-to-polkadot-v0-9-0
MRamanenkau
commented
Sep 19, 2022
MRamanenkau
commented
Sep 19, 2022
MRamanenkau
force-pushed
the
feature/update-to-polkadot-v0-9-0
branch
from
0dbaa7d to
d16d22c
Compare
…-to-polkadot-v0-9-0
AndreiNavoichyk
left a comment
AndreiNavoichyk
left a comment
There was a problem hiding this comment.
@MRamanenkau
At what version did these changes appear? Let's fix them there.
Author
The diff is not significant. At the same time it might be time consuming to rebuild the artifacts and the tests (also, it would be nice to run our blockchain tests against new artifacts). I propose to fix them in the next version. |
Agree. Let's fix in 0.9.3 |
AndreiNavoichyk
previously approved these changes
Sep 23, 2022
AndreiNavoichyk
changed the base branch from
feature/update-to-polkadot-v0-8-30
to
dev-cere
AndreiNavoichyk
approved these changes
Nov 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreiNavoichyk
Checked primitives, frame, utils, clien.
Found diffs:
use sp_std::{prelude::*, rc::Rc, vec};vsuse sp_std::{prelude::*, rc::Rc};in primitives/npos-elections/src/phragmms.rsConfigvsTraitin frame/support/test/tests/pallet_with_name_trait_is_valid.rssc-tracing = { version = "3.0.0", path = "../tracing" }vs empty line in client/executor/Cargo.tomltest-case = "2.2.1"vs empty line in client/executor/Cargo.toml