Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@cmichi
Copy link
Contributor

@cmichi cmichi commented Apr 27, 2021

I ran into a strange panic in this crate when syncing canvas-node to Substrate. Upgrading this dependency seems to fix it.

The notable thing is that crate_metadata.workspace_root is a Utf8PathBuf now.

@cmichi cmichi requested a review from bkchr April 27, 2021 02:54
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 27, 2021
@cmichi cmichi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 27, 2021
@bkchr
Copy link
Member

bkchr commented Apr 27, 2021

bot merge

@ghost
Copy link

ghost commented Apr 27, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Apr 27, 2021

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@ghost ghost merged commit 926c1ec into master Apr 27, 2021
@ghost ghost deleted the cmichi-update-cargo-metadata-dep branch April 27, 2021 07:17
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants