Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@ascjones
Copy link
Contributor

Should fix CI check test-linux-stable failing with the lock file /builds/parity/substrate/Cargo.lock needs to be updated but --locked was passed to prevent this. https://gitlab.parity.io/parity/substrate/-/jobs/866870#L63

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 25, 2021
@ascjones ascjones added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 25, 2021
@shawntabrizi shawntabrizi added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Mar 25, 2021
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
@ascjones ascjones changed the title Upgrade test runner to use latest libp2p Remove redundant libp2p dependency from test runner Mar 25, 2021
@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Mar 25, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Mar 25, 2021

Checks failed; merge aborted.

@ascjones
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Mar 25, 2021

Waiting for commit status.

@ghost ghost merged commit 2e34d47 into master Mar 25, 2021
@ghost ghost deleted the aj-test-runner-libp2p branch March 25, 2021 13:46
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
* Upgrade test runner to use latest libp2p

* Update test-utils/test-runner/Cargo.toml

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>

* Update Cargo.lock

Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants