Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Introduce macro for building Contains impl based on a match #8675

Merged
gavofyork merged 3 commits into from
Apr 27, 2021
Merged

Introduce macro for building Contains impl based on a match #8675

gavofyork merged 3 commits into from
Apr 27, 2021

Conversation

@gavofyork
Copy link
Member

@gavofyork gavofyork commented Apr 27, 2021

No description provided.

@gavofyork gavofyork added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Apr 27, 2021
gui1117
gui1117 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worth docs with an example and a test, but implementation is good to me

@gavofyork gavofyork merged commit 0856e07 into master Apr 27, 2021
@gavofyork gavofyork deleted the gav-macro-contains branch April 27, 2021 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gui1117 gui1117 gui1117 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork @gui1117