This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Upgrade pallet atomic swap to FRAME v2 #8452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
A0-please_review
ascjones
reviewed
Mar 25, 2021
shawntabrizi
approved these changes
Mar 26, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
hirschenberger
pushed a commit
to hirschenberger/substrate
that referenced
this pull request
Apr 14, 2021
* upgrade pallet atomic swap * fix doc
apopiak
changed the title
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the atomic swap pallet to the new pallet attribute macro
Part of #7882.
Upgrade guidelines used.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the atomic swap pallet must be careful about the name they used in
construct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of the atomic swap pallet.For polkadot and kusama atomic swap is not used, thus no migration needed there.