feat: Keep volume level across audio devices #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @XangelMusic for code |
|
I've put up a pull request to add @XangelMusic! 🎉 |
Belphemur
requested changes
Dec 16, 2023
Co-authored-by: Antoine Aflalo <[email protected]>
Belphemur
approved these changes
Dec 16, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
## [6.8.0](v6.7.2...v6.8.0) (2023-12-19) ### Enhancements * **.NET:** Move to .NET 8.0 ([43f0d60](43f0d60)) * **device::cache:** Improve the performance and speed of caching devices ([594b49c](594b49c)) * **device::cache:** Increase the TTL for refreshing device list ([6ab8028](6ab8028)) * **device::cache:** keep only one cache alive for all devices ([9b3a126](9b3a126)) * **device::cache:** rework the logic behind refreshing devices when changes are detected in the system. ([3c12b3f](3c12b3f)) ### Languages * **Bulgarian:** Translated Settings using Weblate ([b2cf464](b2cf464)) * **Bulgarian:** Translated Tray Icon using Weblate ([fffe534](fffe534)) * **Chinese (Traditional):** Translated Settings using Weblate ([4582119](4582119)) * **French:** Translated Settings using Weblate ([4496335](4496335)) * **French:** Translated Tray Icon using Weblate ([76905a4](76905a4)) * **French:** Translated Update Download using Weblate ([67c281b](67c281b)) * **German:** Translated Settings using Weblate ([061583c](061583c)) * **German:** Translated Tray Icon using Weblate ([3da0c83](3da0c83)) * **Korean:** Translated Tray Icon using Weblate ([4ca2b15](4ca2b15)) * **Polish:** Translated Settings using Weblate ([43f8fa2](43f8fa2)) * **Polish:** Translated Tray Icon using Weblate ([3b05aeb](3b05aeb)) * **Polish:** Translated Update Download using Weblate ([6cd0022](6cd0022)) * **Serbian:** Translated Tray Icon using Weblate ([d17e650](d17e650)) * **Slovenian:** Translated Tray Icon using Weblate ([b8c4269](b8c4269)) * **Swedish:** Translated About using Weblate ([2b0a112](2b0a112)) * **Swedish:** Translated About using Weblate ([943befb](943befb)) * **Swedish:** Translated Settings using Weblate ([9a182a1](9a182a1)) * **Swedish:** Translated Settings using Weblate ([49d3fcc](49d3fcc)) * **Swedish:** Translated Settings using Weblate ([f2eb255](f2eb255)) * **Swedish:** Translated Settings using Weblate ([d9e285f](d9e285f)) * **Swedish:** Translated Settings using Weblate ([3454648](3454648)) * **Swedish:** Translated Tray Icon using Weblate ([e939073](e939073)) * **Swedish:** Translated Tray Icon using Weblate ([fe21446](fe21446)) * **Swedish:** Translated Update Download using Weblate ([c95fe6e](c95fe6e)) * **Swedish:** Translated Update Download using Weblate ([1b65fa4](1b65fa4)) ### Bug Fixes * **Device::Cache:** Devices not being refreshed ([a113175](a113175)), closes [#1323](#1323) * **profile:** possible issue with profile where the the state couldn't be restored after the profile ended. ([a648e4e](a648e4e)) ### Features * **volume:** Add an option to keep volume level across audio devices ([ca293b5](ca293b5)), closes [#1328](#1328)
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a function called SetVolumeFromDefaultDevice in the AudioSwitcher lib.
Created a new checkbox "Keep volume across playback devices" in Settings along with numerous KeepVolume values throughout the code for this checkbox.
This allows the user to keep the same volume level when switching devices. As a design choice, it can only switch between playback devices. This can be changed in the boolean inside the SetActiveDevice function of the ADeviceCycler lib.
n.b. SetVolumeFromDefaultDevice can be used for both Playback and Recording devices.