-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.1 Deployment #3313
7.1 Deployment #3313
Conversation
…com/BHoM/BHoM_Engine into Analytical_oM-#487-RenameProperties
…2D methods to Query class and folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for Lighting using the March 14th beta artefact, all is behaving as expected per the test procedure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from Interop.
Initially, there was an error in one of the Hash/Diffing tests. However, this proved a false flag after further investigation. This was recorded in the Interop Test plan.
Reviewed for Facades using March 18th beta artefact. Noting in Section 3.0 there is a reference to matching values in green panels but green panels do not appear in test script. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 27 requests in the queue ahead of you. |
Please be advised that the check with reference 22829283114 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 450 additional annotations waiting, made up of 16 errors and 434 warnings. |
Please be advised that the check with reference 22829296296 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 2593 additional annotations waiting, made up of 34 errors and 2559 warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for MEP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming that Geometry_Engine works as expected within the scope I have touched during this milestone.
Reviewed for Facades using the March 19 beta artefact, all is behaving as expected per the test procedure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for structures elements and happy they are included in the 7.1.240323.beta
@bhombot-ci[bot] just to let you know, I have provided a |
1 similar comment
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environments Engine OK for merging as per the 7.1 test plan
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: null-handling, serialisation, dataset-compliance, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs have been reviewed by DevOps and bot checks and are suitable for deployment for updating copyright headers to 2024. Approving for merge.
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-documentation-compliance. If you are providing dispensation on this occasion, please reply with:
|
FAO: @FraserGreenroyd The check they wish to have dispensation on is beta-code-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 22829296296 |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 22829283114 |
@FraserGreenroyd I have now provided a passing check on reference |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs have been reviewed by DevOps and are suitable for the deployment of develop
to the 7.1 beta. Approving for merge.
@bhombot-ci[bot] just to let you know, I have provided a |
BHoM_Engine
Feature
BH.Engine.Base.Query.Hash()
method now leverages theBH.Engine.Geometry.Query.GeometryHash()
method by default. This can give a significant speed boost, for an average of 33% less computation time, and a potential 99% for heavy geometry inputs.BH.Engine.Geometry.Query.HashArray()
method now makes use of theBaseComparisonConfig
options, bringing it on par to the baseBH.Engine.Base.Query.Hash()
method in terms of identification potential for Geometry objects.FuzzyMatch
using the Levenshtein method (using the FuzzySharp library)ExtractOne
,ExtractTop
,ExtractAll
andExtractSorted
which has two overload methods, one to define theScorer
and one to provideList<BHoMObjects
and a property name to use to compare against a query (e.g.SectionProperty.Material.Name
)Extract
method has different outputs that can be modified, for example the number of results to return or a cutoff for the scoring.Bug
Structure.Query.Mass(Panel)
method that was not accounting forReinforcementDensity
.TimberSection
to haveITimber
as an input;Compliance
StartNode
toStart
and fromEndNode
toEnd
Documentation
User-experience