Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure_Engine: Update Timber constructors to accept ITimber as inputs #3309

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/BHoM#1603

Issues addressed by this PR

Closes #3308

Test files

Test script

Changelog

  • Updated constructors the TimberSection to have ITimber as an input;

Additional comments

@peterjamesnugent peterjamesnugent added the type:bug Error or unexpected behaviour label Mar 3, 2024
@peterjamesnugent peterjamesnugent self-assigned this Mar 3, 2024
@peterjamesnugent
Copy link
Member Author

peterjamesnugent commented Mar 3, 2024

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd changed the title Update Timber constructors to accept ITimber as inputs Structure_Engine: Update Timber constructors to accept ITimber as inputs Mar 4, 2024
Copy link

bhombot-ci bot commented Mar 4, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 4, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 4, 2024

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Mar 4, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with changes. Code change makes sense and test works as intended. Approved

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check unit-tests

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Mar 4, 2024

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 4, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, ought to add Previous version attributes on those methods. They are correctly deserialising right now, but they should not be. Will raise an issue to investigate why this is. So, should add the attributes to make sure the methods upgrade correctly once serialiser is fixed.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Mar 4, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Mar 4, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re=approving after addition of PreviousVersion attributes

Copy link

bhombot-ci bot commented Mar 4, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Mar 4, 2024

@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you.

Copy link

bhombot-ci bot commented Mar 4, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Mar 4, 2024

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 55ad027 into develop Mar 4, 2024
13 checks passed
@IsakNaslundBh IsakNaslundBh deleted the Structure_oM-#1518-UpdateTimberToITimber branch March 4, 2024 10:36
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structure_Engine: TimberSection Create method only takes Timber materials, but it should take ITImber
3 participants