-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Update Timber constructors to accept ITimber as inputs #3309
Structure_Engine: Update Timber constructors to accept ITimber as inputs #3309
Conversation
@peterjamesnugent to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
The check |
The check |
@peterjamesnugent just to let you know, I have provided a |
@peterjamesnugent just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with changes. Code change makes sense and test works as intended. Approved
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, ought to add Previous version attributes on those methods. They are correctly deserialising right now, but they should not be. Will raise an issue to investigate why this is. So, should add the attributes to make sure the methods upgrade correctly once serialiser is fixed.
@IsakNaslundBh to confirm, the following actions are now queued:
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re=approving after addition of PreviousVersion attributes
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@IsakNaslundBh I'm sorry, but I am not authorised to take that instruction from you. |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@peterjamesnugent just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM#1603
Issues addressed by this PR
Closes #3308
Test files
Test script
Changelog
TimberSection
to haveITimber
as an input;Additional comments