Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial_Engine: Remove unnecessary area methods #3244

Merged

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #2086

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 5 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On code review, approving as this covers points set out in original issue(s).

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Jan 12, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 0411dda into develop Jan 12, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Spatial_Engine-#2086-RemoveUnecessaryMethods branch January 12, 2024 15:26
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial_Engine: There should be no Area method for IElement1D and IElement0D
2 participants