-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure_Engine: Fix bug for the Mass method (for Panels) #3256
Structure_Engine: Fix bug for the Mass method (for Panels) #3256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked using test script.
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check required |
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
There are 8 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last commit was only to unit tests, @MayaAroraJonsson previous review for functionality is still valid, so approving for merge based on that.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Issues addressed by this PR
Closes #2854
Test files
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Engine/Structure_Engine/%232854-MassPerAreaNotAccountingForReinforcementDensity/%232854.gh?csf=1&web=1&e=umvd2d
Changelog
Structure.Query.Mass(Panel)
method that was not accounting forReinforcementDensity
.Additional comments
The two
Mass
methods are quite old, is there an argument they are redundant now we have theMass
methods forIElementM
andIElement1D
?