Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search_Engine: Migrate Search_Engine to BHoM_Engine #3247

Merged
merged 12 commits into from
Jan 26, 2024

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/BHoM#1586

Issues addressed by this PR

Closes #3211

Test files

Fuzzy Matching

Changelog

  • Added FuzzyMatch using the Levenshtein method (using the FuzzySharp library)
  • Added ExtractOne, ExtractTop, ExtractAll and ExtractSorted which has two overload methods, one to define the Scorer and one to provide List<BHoMObjects and a property name to use to compare against a query (e.g. SectionProperty.Material.Name)
  • Each Extract method has different outputs that can be modified, for example the number of results to return or a cutoff for the scoring.

Additional comments

@peterjamesnugent
Copy link
Member Author

@BHoMBot check code compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check copyright-compliance
  • check documentation-compliance
  • check project-compliance

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick initial comments for today - will do more during the week when testing

Search_Engine/Search_Engine.csproj Outdated Show resolved Hide resolved
Search_Engine/Search_Engine.csproj Outdated Show resolved Hide resolved
Search_Engine/Search_Engine.csproj Outdated Show resolved Hide resolved
Search_Engine/Search_Engine.csproj Show resolved Hide resolved
@peterjamesnugent
Copy link
Member Author

@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check copyright-compliance
  • check documentation-compliance
  • check project-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check code-compliance
@BHoMBot check copyright-compliance
@BHoMBot check documentation-compliance
@BHoMBot check project-compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check copyright-compliance
  • check documentation-compliance
  • check project-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check code-compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance

Search_Engine/Compute/Extract/ExtractAll.cs Outdated Show resolved Hide resolved
Search_Engine/Compute/Extract/ExtractAll.cs Outdated Show resolved Hide resolved
Search_Engine/Compute/Extract/ExtractOne.cs Outdated Show resolved Hide resolved
Search_Engine/Compute/Extract/ExtractSorted.cs Outdated Show resolved Hide resolved
Search_Engine/Compute/Extract/ExtractSorted.cs Outdated Show resolved Hide resolved
Search_Engine/Compute/Ratios/FuzzyMatch.cs Outdated Show resolved Hide resolved
Search_Engine/Search_Engine.csproj Show resolved Hide resolved
Search_Engine/Search_Engine.csproj Outdated Show resolved Hide resolved
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 23, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 14 requests in the queue ahead of you.

@peterjamesnugent peterjamesnugent dismissed FraserGreenroyd’s stale review January 23, 2024 15:43

Changes addressed in commits

Copy link

bhombot-ci bot commented Jan 23, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 23, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 23, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@peterjamesnugent peterjamesnugent force-pushed the AGS_Toolkit-#3-PrototypingWithFuzzyMatching branch from a80c093 to 2fb28f3 Compare January 26, 2024 09:38
@peterjamesnugent
Copy link
Member Author

@BHoMBot check required
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 26, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 19 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Jan 26, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 26, 2024

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 26, 2024

@peterjamesnugent just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

Copy link

bhombot-ci bot commented Jan 26, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Jan 26, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, core

Copy link

bhombot-ci bot commented Jan 26, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Jan 26, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Jan 26, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments have been addressed by @peterjamesnugent and code review shows this looks good for a first pass, so approving for merge to alphas for further testing.

Copy link

bhombot-ci bot commented Jan 26, 2024

@peterjamesnugent just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit b93e562 into develop Jan 26, 2024
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the AGS_Toolkit-#3-PrototypingWithFuzzyMatching branch January 26, 2024 10:13
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search_Engine: Implement fuzzy matching
3 participants