-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search_Engine: Migrate Search_Engine to BHoM_Engine #3247
Search_Engine: Migrate Search_Engine to BHoM_Engine #3247
Conversation
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick initial comments for today - will do more during the week when testing
@peterjamesnugent to confirm, the following actions are now queued:
|
@peterjamesnugent to confirm, the following actions are now queued:
|
@BHoMBot check code-compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
4cdab12
to
5bbfdc3
Compare
5bbfdc3
to
905d3b3
Compare
@peterjamesnugent to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
Changes addressed in commits
The check |
The check |
The check |
… file as it's private
…ct reference and remove reference to FuzzyResult
a80c093
to
2fb28f3
Compare
@peterjamesnugent to confirm, the following actions are now queued:
There are 19 requests in the queue ahead of you. |
The check |
The check |
@peterjamesnugent just to let you know, I have provided a |
@peterjamesnugent just to let you know, I have provided a |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, core |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments have been addressed by @peterjamesnugent and code review shows this looks good for a first pass, so approving for merge to alphas for further testing.
@peterjamesnugent just to let you know, I have provided a |
NOTE: Depends on
BHoM/BHoM#1586
Issues addressed by this PR
Closes #3211
Test files
Fuzzy Matching
Changelog
FuzzyMatch
using the Levenshtein method (using the FuzzySharp library)ExtractOne
,ExtractTop
,ExtractAll
andExtractSorted
which has two overload methods, one to define theScorer
and one to provideList<BHoMObjects
and a property name to use to compare against a query (e.g.SectionProperty.Material.Name
)Extract
method has different outputs that can be modified, for example the number of results to return or a cutoff for the scoring.Additional comments