Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' #1130

Closed
1 task done
Menghua1 opened this issue Mar 5, 2024 · 10 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@Menghua1
Copy link
Member

Menghua1 commented Mar 5, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/insights/component

(Optional) Module Name if not listed above

avm/res/insights/component

(Optional) Module Version

No response

Description

Please add the creation of Microsoft.Portal/dashboards and the output applicationInsights.properties.ConnectionString.
For example (azd):
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep#L19
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep#L28

CC: @jongio

(Optional) Correlation Id

No response

@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: Feature Request ➕ New feature or request labels Mar 5, 2024
@github-actions github-actions bot added the Class: Resource Module 📦 This is a resource module label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

@Menghua1, thanks for submitting this issue for the avm/res/insights/component module!

A member of the @azure/avm-res-insights-component-module-owners-bicep or @azure/avm-res-insights-component-module-contributors-bicep team will review it soon!

ChrisSidebotham pushed a commit that referenced this issue Mar 7, 2024
…ule (#1137)

## Description

Added a new output `connectionString` to the App Insights module.

This change has been requested via #1130 , however the issue contains
one more request, therefore not closing the issue automatically from
here.

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.insights.component](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml/badge.svg?branch=users%2Fkrbar%2F1130_appInsightsOutput)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Mar 8, 2024
@AlexanderSehr AlexanderSehr removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Mar 8, 2024
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Mar 12, 2024
…ule (Azure#1137)

## Description

Added a new output `connectionString` to the App Insights module.

This change has been requested via Azure#1130 , however the issue contains
one more request, therefore not closing the issue automatically from
here.

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.insights.component](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml/badge.svg?branch=users%2Fkrbar%2F1130_appInsightsOutput)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml)
|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
@v-xuto
Copy link
Member

v-xuto commented Mar 26, 2024

@krbar Do you have an ETA for this?

@Menghua1
Copy link
Member Author

The issue of the output parameters applicationInSights.properties.connectionString has been fixed by hundredacres@038de41.

@zedy-wj
Copy link
Member

zedy-wj commented Jun 6, 2024

This issue is fixing by pr: #2016.

@Menghua1 Menghua1 changed the title [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' and the output 'applicationInsights.properties.ConnectionString' [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' Jun 11, 2024
@krbar
Copy link
Contributor

krbar commented Jun 20, 2024

Dear @Menghua1,

please note that after merging the PR 2016 the following resource modules are now available:

If I understand correctly, you need a pattern module that deploys these resources together. Can you confirm?

If yes, please be aware that this will require a separate module proposal for the new pattern, which you can submit here. This proposal needs a module owner responsible for developing and maintaining the module. While we can assist with the initial development, we cannot take on ownership of this module. Would you or someone from your team be willing to own it? If so, do you need help with the initial development?

CC: @matebarabas @jtracey93 @jongio @puicchan

@Menghua1
Copy link
Member Author

@jongio Do you have any ideas? Now, as the Portal Dashboard is independent module, when moving azd to use avm, need to set about 1000 lines content to the Portal Dashboard module to associate Application Insights and the code is here: https://github.com/Azure/azure-dev/blob/avmupdates/templates/todo/common/infra/bicep/app/applicationinsights-dashboard.bicep

@jongio
Copy link
Member

jongio commented Jun 21, 2024

Let's keep that in azure-dev repo for now and take the pattern modules as a separate effort.

@v-xuto
Copy link
Member

v-xuto commented Jun 24, 2024

@jongio Got it. Besides, we will submit a new module here to deploy these resources together. Should our team take ownership of this module and develop it?

@Menghua1
Copy link
Member Author

Menghua1 commented Aug 6, 2024

@jongio we have opened a new Module Proposal issue here: Azure/Azure-Verified-Modules#1206. If there are no problems, we will close this issue.

@jongio
Copy link
Member

jongio commented Aug 6, 2024

Ok

@Menghua1 Menghua1 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants