-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the creation of 'Microsoft.Portal/dashboards' in Insights Module - avm/res/insights/component
#1974
Conversation
Hey @zedy-wj,
What it qualifies for is subject to debate as the spec leaves a bit of wiggle room and it comes down to
As this is not an easy answer, I'd also as the other maintainers @jtracey93, @eriqua, @ChrisSidebotham and of course the module owner @krbar to share your thoughts. |
thanks for the PR. I think this feels like a new pattern module to me. As the dashboards could be a resource module own their own, and should be ideally. Then can be wrapped in many pattern modules |
for now, let's get the dashboard module created if not there yet |
Module proposal for the Dashboard module: Azure/Azure-Verified-Modules#980 |
Thanks @zedy-wj for raising this PR and triggering this discussion.
+1 on the above. |
Requires approved module proposal and prior publication to the MAR manifest. Do not merge, until both are confirmed here. |
Sorry if I missed it: what's the plan for this PR? |
@eriqua - Currently #2016 is dealing with the creation of the dashboard module, this PR did not develop the dashboard as an independent module. We will close this PR and move the plan to fix #1130 to #2016. @jongio - We will close this PR and move the plan to fix #1130 to #2016. |
Description
Fixes #1130
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.@jongio - for notification.