Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/res/portal/dashboard #980

Closed
2 tasks done
krbar opened this issue May 21, 2024 · 6 comments
Closed
2 tasks done

[Module Proposal]: avm/res/portal/dashboard #980

krbar opened this issue May 21, 2024 · 6 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@krbar
Copy link
Contributor

krbar commented May 21, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Resource Module

Module Name

avm/res/portal/dashboard

Module Details

New module, resulting of Azure/bicep-registry-modules#1130

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

krbar

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@matebarabas
Copy link
Contributor

Hi @krbar,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label May 21, 2024
@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Resource Module 📦 This is a resource module and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels May 21, 2024
@krbar
Copy link
Contributor Author

krbar commented May 23, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@matebarabas
Copy link
Contributor

Hi @krbar,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team

@matebarabas matebarabas removed Needs: Triage 🔍 Maintainers need to triage still Status: In Triage 🔍 Picked up for triaging by an AVM core team member labels May 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Jun 14, 2024
@krbar
Copy link
Contributor Author

krbar commented Jun 14, 2024

PR in review: Azure/bicep-registry-modules#2016

@matebarabas matebarabas added Status: In PR 👉 This is when an issue is due to be fixed in an open PR and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Jun 14, 2024
jtracey93 pushed a commit to Azure/bicep-registry-modules that referenced this issue Jun 19, 2024
## Description

New Module `avm/res/portal/dashboard`.

Related Module Proposal:
Azure/Azure-Verified-Modules#980

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Pipeline references

| Pipeline |
| - |
|
[![avm.res.portal.dashboard](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.portal.dashboard.yml/badge.svg?branch=users%2Fkrbar%2FportalDashboardModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.portal.dashboard.yml)
|
@jtracey93
Copy link
Contributor

@matebarabas PR merged, can you take the proposal issue from here?

@jtracey93 jtracey93 added Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Core Team 🧞 This item needs the AVM Core Team to review it labels Jun 19, 2024
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this issue Jun 19, 2024
## Description

New Module `avm/res/portal/dashboard`.

Related Module Proposal:
Azure/Azure-Verified-Modules#980

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [ ] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

## Pipeline references

| Pipeline |
| - |
|
[![avm.res.portal.dashboard](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.portal.dashboard.yml/badge.svg?branch=users%2Fkrbar%2FportalDashboardModule)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.portal.dashboard.yml)
|
@matebarabas matebarabas added Status: Module Available 🟢 The module is published and removed Status: In PR 👉 This is when an issue is due to be fixed in an open PR labels Jun 20, 2024
@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.

Thank you for your work @krbar! I'm closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
Development

No branches or pull requests

3 participants