Update the infra/core modules to AVM modules of "todo-python-mongo" #3872
Conversation
| } | ||
| } | ||
|
|
||
| // The application backend | ||
| module api '../../../../../common/infra/bicep/app/api-appservice-python.bicep' = { | ||
| name: 'api' | ||
| module api 'br/public:avm/res/web/site:0.2.0' = { |
There was a problem hiding this comment.
I liked having all of these settings in a different file isolated from the user.
IMO this experience is a degredation from previous experience. Can you put these common settings into relevant files, like /app/api.bicp, like we used to have?
And then share those in all the new AVM updated templates.
There was a problem hiding this comment.
We are fixing Azure/bicep-registry-modules#1124, it will be configured in the avm relevant service, and the common configuration file is no longer needed.
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Menghua1
changed the title
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/3872You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3872View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/3872You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3872View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/3872You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/3872View Changes | Compare Changes Project: todo-python-mongo-terraformRemote: azure-samples-stagingBranch: pr/3872You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3872View Changes | Compare Changes |
| keyvault_name_as_attr(secret.name), | ||
| keyvault_client.get_secret(secret.name).value, | ||
| ) | ||
| if secret.name == "AZURE-COSMOS-CONNECTION-STRING": |
There was a problem hiding this comment.
Why update to only set this secret?
There was a problem hiding this comment.
Because when using infra/core/database to create Cosmos Mongo, only one secret named "AZURE-COSMOS-CONNECTION-STRING" will be created in keyVault, the specific code is here.
But now when using AVM to create Cosmos Mongo, multiple secrets are created and the specific code is here. The backend will fail to obtain "AZURE-COSMOS-CONNECTION-STRING" in the secret. It will succeed only when secret.name == "AZURE-COSMOS-CONNECTION-STRING" is specified.
Update the infra/core modules to AVM modules for
todo-python-mongo.1. Modules not replaced by AVM
Monitoring (applicationinsights-dashboard) : Missing the feature
Microsoft.Portal/dashboards.AVM issue link: [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' bicep-registry-modules#1130
APIM: Missing features
Microsoft.ApiManagement/service/loggers,Microsoft.ApiManagement/service/apis/diagnostics.AVM issue link: [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' bicep-registry-modules#1124
2. Modules replaced by AVM
@jongio for notification.