-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454
Conversation
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issue adopting AVM and migrating away from our home grown core modules.
If we move forward we should update all the templates and deprecate the core modules.
One way to approach this would be to PR into a feature branch and then merge the feature branch back into main when these updates are completed.
Repoman does the branch on each template automatically. Shouldn't it be a duplication to branch azure-dev as well? |
webFrontendUrl: 'https://${web.outputs.defaultHostname}' | ||
apiBackendUrl: 'https://${api.outputs.defaultHostname}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this format in a variable b/c it is used in multiple places.
appInsightResourceId: resourceId(subscription().subscriptionId, rg.name, 'Microsoft.insights/components', monitoring.outputs.applicationInsightsName) | ||
siteConfig: { | ||
windowsFxVersion: 'node|18-lts' | ||
appCommandLine: './entrypoint.sh -o ./env-config.js && pm2 serve /home/site/wwwroot --no-daemon --spa' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vhvb1989 are you moving away from entrypoint.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP: #3171
Please try to make this work without any modules from infra/core. I want to see what all the gaps look like |
@jongio I have updated the code, please review. There are two questions that need to be clarified:
|
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Can you please reference the issues that we have filed for each of the above? |
|
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
d858ca6
to
97dd7ea
Compare
/azp run azure-dev - repoman |
Azure Pipelines successfully started running 1 pipeline(s). |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/3454You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3454 View Changes | Compare Changes |
Update the infra/core modules to AVM modules for
todo-nodejs-mongo
.1. Modules not replaced by AVM
Cosmos DB: Missing the feature
Microsoft.KeyVault/vaults/secrets
and the outputconnectionStringKey
, so we cannot store theconnection string
into keyvault.AVM issue link: DocumentDB: avm and setting implicit keyvault secrets for connection strings #611 bicep-registry-modules#632
Monitoring (app insights) : Missing the feature
Microsoft.Portal/dashboards
and the outputapplicationInsights.properties.ConnectionString
.AVM issue link: [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' bicep-registry-modules#1130
APIM: Missing features
Microsoft.ApiManagement/service/loggers
,Microsoft.ApiManagement/service/apis/diagnostics
.AVM issue link: [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' bicep-registry-modules#1124
2. Modules replaced by AVM
@jongio for notification.