Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454

dotnet-7 · 2024-02-29T09:20:08Z

Update the infra/core modules to AVM modules for todo-nodejs-mongo.

1. Modules not replaced by AVM

Cosmos DB: Missing the feature Microsoft.KeyVault/vaults/secrets and the output connectionStringKey, so we cannot store the connection string into keyvault.
AVM issue link: DocumentDB: avm and setting implicit keyvault secrets for connection strings #611 bicep-registry-modules#632
Monitoring (app insights) : Missing the feature Microsoft.Portal/dashboards and the output applicationInsights.properties.ConnectionString.
AVM issue link: [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' bicep-registry-modules#1130
APIM: Missing features Microsoft.ApiManagement/service/loggers, Microsoft.ApiManagement/service/apis/diagnostics.
AVM issue link: [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' bicep-registry-modules#1124

2. Modules replaced by AVM

App Service
Key Vault
App Service Plan

@jongio for notification.

vhvb1989 · 2024-02-29T19:05:13Z

/azp run azure-dev - repoman

azure-pipelines · 2024-02-29T19:05:26Z

Azure Pipelines successfully started running 1 pipeline(s).

vhvb1989

LGTM and tests passed

wbreza

I have no issue adopting AVM and migrating away from our home grown core modules.
If we move forward we should update all the templates and deprecate the core modules.

One way to approach this would be to PR into a feature branch and then merge the feature branch back into main when these updates are completed.

vhvb1989 · 2024-03-01T05:45:59Z

I have no issue adopting AVM and migrating away from our home grown core modules. If we move forward we should update all the templates and deprecate the core modules.

One way to approach this would be to PR into a feature branch and then merge the feature branch back into main when these updates are completed.

Repoman does the branch on each template automatically. Shouldn't it be a duplication to branch azure-dev as well?
Keep in mind that we are updating the todo-templates, while the core modules are still available for anyone from the repo. We can keep those around for a while

jongio · 2024-02-29T22:57:41Z

templates/todo/projects/nodejs-mongo/.repo/bicep/infra/main.bicep

+    webFrontendUrl: 'https://${web.outputs.defaultHostname}'
+    apiBackendUrl: 'https://${api.outputs.defaultHostname}'


Let's get this format in a variable b/c it is used in multiple places.

jongio · 2024-02-29T22:58:55Z

templates/todo/projects/nodejs-mongo/.repo/bicep/infra/main.bicep

+    appInsightResourceId: resourceId(subscription().subscriptionId, rg.name, 'Microsoft.insights/components', monitoring.outputs.applicationInsightsName)
+    siteConfig: {
+      windowsFxVersion: 'node|18-lts'
+      appCommandLine: './entrypoint.sh -o ./env-config.js && pm2 serve /home/site/wwwroot --no-daemon --spa'


@vhvb1989 are you moving away from entrypoint.sh?

jongio · 2024-03-08T22:03:40Z

Please try to make this work without any modules from infra/core. I want to see what all the gaps look like

v-jiaodi · 2024-03-13T10:23:01Z

@jongio I have updated the code, please review.

There are two questions that need to be clarified:

For applicationInsightsDashboard, Microsoft.ApiManagement/service/loggers and Microsoft.ApiManagement/service/apis/diagnostics, since it was not implemented in AVM, we have retained the original implementation.
Remove apim service sku config. For Consumption SKU Type capacity must be specified as 0, but in AVM , only 1 and 2 are allowed: https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/api-management/service/main.bicep#L68
For cosmosConnectString, we store in keyVault by listConnectionStrings(resourceId, '2022-08-15').connectionStrings[0].connectionString

v-xuto · 2024-03-15T03:15:49Z

/azp run azure-dev - repoman

azure-pipelines · 2024-03-15T03:16:01Z

Azure Pipelines successfully started running 1 pipeline(s).

jongio · 2024-03-26T19:19:35Z

@jongio I have updated the code, please review.

There are two questions that need to be clarified:

For applicationInsightsDashboard, Microsoft.ApiManagement/service/loggers and Microsoft.ApiManagement/service/apis/diagnostics, since it was not implemented in AVM, we have retained the original implementation.

Remove apim service sku config. For Consumption SKU Type capacity must be specified as 0, but in AVM , only 1 and 2 are allowed: https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/api-management/service/main.bicep#L68

For cosmosConnectString, we store in keyVault by listConnectionStrings(resourceId, '2022-08-15').connectionStrings[0].connectionString

Can you please reference the issues that we have filed for each of the above?

v-jiaodi · 2024-03-28T07:13:04Z

@jongio

Monitoring (app insights) : Missing the feature Microsoft.Portal/dashboards, since it was not implemented in AVM, we have retained the original implementation. [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' bicep-registry-modules#1130
APIM: Missing features Microsoft.ApiManagement/service/loggers and Microsoft.ApiManagement/service/apis/diagnostics.
[AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' bicep-registry-modules#1124

v-xuto · 2024-05-29T03:18:16Z

/azp run azure-dev - repoman

azure-pipelines · 2024-05-29T03:18:28Z

Azure Pipelines successfully started running 1 pipeline(s).

v-xuto · 2024-05-30T02:25:35Z

/azp run azure-dev - repoman

azure-pipelines · 2024-05-30T02:25:46Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2024-05-30T02:28:40Z

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/3454

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/3454

View Changes | Compare Changes

update avaliable modules from core to avm

4048dcc

microsoft-github-policy-service bot assigned dotnet-7 Feb 29, 2024

add missing content

ce260f3

dotnet-7 marked this pull request as ready for review February 29, 2024 10:13

dotnet-7 requested review from jongio and wbreza as code owners February 29, 2024 10:13

vhvb1989 approved these changes Feb 29, 2024

View reviewed changes

wbreza reviewed Feb 29, 2024

View reviewed changes

jongio marked this pull request as draft February 29, 2024 22:56

replace keyvault access and web app setting with avm version

97dd7ea

jongio requested changes Mar 4, 2024

View reviewed changes

Azure deleted a comment from azure-sdk Mar 15, 2024

Azure deleted a comment from azure-pipelines bot Mar 15, 2024

dotnet-7 force-pushed the avm branch 3 times, most recently from d858ca6 to 97dd7ea Compare May 29, 2024 09:14

Menghua1 changed the title ~~Update the infra/core modules to AVM modules~~ Update the infra/core modules to AVM modules of "todo-nodejs-mongo" May 29, 2024

SenyangCai added 2 commits May 29, 2024 17:21

add content

bac4af0

remove appsetting

9b494ec

SenyangCai and others added 7 commits May 29, 2024 17:56

remove change

eb80f3f

remove change

64ded8a

update repo

243cde0

update repo

41a9744

remove error

4f8d128

remove error

3a8eaaf

Merge branch 'main' into avm

0e6a532

Update repo.yaml

2df6628

v-xuto closed this Jun 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454

Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454

dotnet-7 commented Feb 29, 2024 •

edited

Loading

vhvb1989 commented Feb 29, 2024

azure-pipelines bot commented Feb 29, 2024

vhvb1989 left a comment

wbreza left a comment

vhvb1989 commented Mar 1, 2024

jongio Feb 29, 2024

jongio Feb 29, 2024

vhvb1989 Mar 4, 2024

jongio commented Mar 8, 2024

v-jiaodi commented Mar 13, 2024 •

edited

Loading

v-xuto commented Mar 15, 2024

azure-pipelines bot commented Mar 15, 2024

jongio commented Mar 26, 2024

v-jiaodi commented Mar 28, 2024

v-xuto commented May 29, 2024

azure-pipelines bot commented May 29, 2024

v-xuto commented May 30, 2024

azure-pipelines bot commented May 30, 2024

azure-sdk commented May 30, 2024

		webFrontendUrl: 'https://${web.outputs.defaultHostname}'
		apiBackendUrl: 'https://${api.outputs.defaultHostname}'

Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454

Update the infra/core modules to AVM modules of "todo-nodejs-mongo" #3454

Conversation

dotnet-7 commented Feb 29, 2024 • edited Loading

vhvb1989 commented Feb 29, 2024

azure-pipelines bot commented Feb 29, 2024

vhvb1989 left a comment

Choose a reason for hiding this comment

wbreza left a comment

Choose a reason for hiding this comment

vhvb1989 commented Mar 1, 2024

jongio Feb 29, 2024

Choose a reason for hiding this comment

jongio Feb 29, 2024

Choose a reason for hiding this comment

vhvb1989 Mar 4, 2024

Choose a reason for hiding this comment

jongio commented Mar 8, 2024

v-jiaodi commented Mar 13, 2024 • edited Loading

v-xuto commented Mar 15, 2024

azure-pipelines bot commented Mar 15, 2024

jongio commented Mar 26, 2024

v-jiaodi commented Mar 28, 2024

v-xuto commented May 29, 2024

azure-pipelines bot commented May 29, 2024

v-xuto commented May 30, 2024

azure-pipelines bot commented May 30, 2024

azure-sdk commented May 30, 2024

Repoman Generation Results

Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/3454

dotnet-7 commented Feb 29, 2024 •

edited

Loading

v-jiaodi commented Mar 13, 2024 •

edited

Loading