Use both NPM_CONFIG_USERCONFIG and NPM_CONFIG_REGISTRY to give the pi…#14463
Merged
chidozieononiwu merged 1 commit intoAzure:mainfrom Mar 11, 2026
Merged
Use both NPM_CONFIG_USERCONFIG and NPM_CONFIG_REGISTRY to give the pi…#14463chidozieononiwu merged 1 commit intoAzure:mainfrom
chidozieononiwu merged 1 commit intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates shared Azure Pipelines templates under eng/common to make npm registry configuration more flexible via NPM_CONFIG_USERCONFIG and NPM_CONFIG_REGISTRY, and refines when authenticated .npmrc files are created during npm publishing.
Changes:
- Add an optional
NpmConfigRegistryparameter and plumb it into template step environments asNPM_CONFIG_REGISTRY. - Remove
SkipAuthenticationfromcreate-authenticated-npmrc.yml, making authentication behavior consistent. - Adjust
npm-publish.ymlso authenticated.npmrccreation happens only for non-npmjs publishing paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/pipelines/templates/steps/update-docsms-metadata.yml | Adds NpmConfigRegistry parameter and exports it as NPM_CONFIG_REGISTRY for the DocsMS metadata update script. |
| eng/common/pipelines/templates/steps/create-tags-and-git-release.yml | Switches npm config support toward registry override for the git release tagging step. |
| eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml | Removes SkipAuthentication and always runs npmAuthenticate@0 after generating .npmrc. |
| eng/common/pipelines/templates/jobs/npm-publish.yml | Moves authenticated .npmrc creation into the non-npmjs publishing branch. |
eng/common/pipelines/templates/steps/create-tags-and-git-release.yml
Outdated
Show resolved
Hide resolved
eng/common/pipelines/templates/steps/create-authenticated-npmrc.yml
Outdated
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
NpmConfigEnvVar
branch
from
5b901d3 to
88e7490
Compare
…peline more flexibility
chidozieononiwu
force-pushed
the
NpmConfigEnvVar
branch
from
88e7490 to
5984782
Compare
Collaborator
|
The following pipelines have been queued for testing: |
weshaggard
approved these changes
Mar 11, 2026
scbedd
approved these changes
Mar 11, 2026
Member
scbedd
left a comment
scbedd
left a comment
There was a problem hiding this comment.
Looks g2g to me. Please run one check of the nightly alpha build with these latest changes. You confirmed that standard release is working.
This was referenced Mar 11, 2026
chidozieononiwu
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 11, 2026
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14463 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
chidozieononiwu
added a commit
to Azure/azure-sdk-for-rust
that referenced
this pull request
Mar 11, 2026
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14463 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPM_CONFIG_USERCONFIGandNPM_CONFIG_REGISTRYto give the pipeline more flexibility.NPM_CONFIG_REGISTRYoverrides all other registry settings in.npmrcnpm-publish.ymlto only create authenticated.npmrcwhen publishing to DevOps