Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14463#45648

Merged
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463
Mar 11, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14463#45648
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14463 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 11, 2026 18:07
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs eng/common pipeline templates with upstream azure-sdk-tools changes to better support custom npm registry configuration and to avoid running Azure DevOps npm authentication steps for npmjs.org releases.

Changes:

  • Add NpmConfigRegistry parameter support and plumb it through to NPM_CONFIG_REGISTRY in relevant steps.
  • Adjust npm-publish job flow so .npmrc creation/authentication runs only for non-npmjs.org registries (where npmAuthenticate@0 is applicable).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/update-docsms-metadata.yml Adds optional NpmConfigRegistry parameter and sets NPM_CONFIG_REGISTRY for the DocsMS metadata update script.
eng/common/pipelines/templates/steps/create-tags-and-git-release.yml Adds optional NpmConfigRegistry parameter and sets NPM_CONFIG_REGISTRY for the tag/release verification script.
eng/common/pipelines/templates/jobs/npm-publish.yml Moves create-authenticated-npmrc.yml under the non-npmjs.org branch to avoid using ADO npmAuthenticate@0 for npmjs.org ESRP publishing.

@chidozieononiwu chidozieononiwu merged commit 3057d6e into main Mar 11, 2026
21 of 25 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-NpmConfigEnvVar-14463 branch March 11, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants