Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14463#37589

Merged
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463
Mar 11, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14463#37589
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14463 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 11, 2026 18:06
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs eng/common pipeline templates with the corresponding updates from azure-sdk-tools PR 14463, primarily to improve npm registry configurability and to scope npm authentication setup to the publish path that needs it.

Changes:

  • Add an optional NpmConfigRegistry parameter to relevant pipeline steps and plumb it through as NPM_CONFIG_REGISTRY.
  • Adjust the npm publish job to only create/authenticate an .npmrc for non-npmjs registries (direct npm publish path).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/update-docsms-metadata.yml Adds NpmConfigRegistry parameter and exports it via NPM_CONFIG_REGISTRY for the docs metadata update script environment.
eng/common/pipelines/templates/steps/create-tags-and-git-release.yml Adds NpmConfigRegistry parameter and exports it via NPM_CONFIG_REGISTRY for tag/release verification scripts that may invoke npm.
eng/common/pipelines/templates/jobs/npm-publish.yml Moves .npmrc creation/authentication into the non-npmjs branch so it only runs for the direct npm publish flow.

@chidozieononiwu chidozieononiwu merged commit 6a5e3ab into main Mar 11, 2026
18 of 22 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-NpmConfigEnvVar-14463 branch March 11, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants