Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14463#56972

Merged
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463
Mar 11, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14463#56972
chidozieononiwu merged 1 commit intomainfrom
sync-eng/common-NpmConfigEnvVar-14463

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14463 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner March 11, 2026 18:07
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates shared Azure DevOps pipeline templates to allow callers to override the npm registry via NPM_CONFIG_REGISTRY, and adjusts when the authenticated .npmrc creation step runs during npm publishing.

Changes:

  • Add a new NpmConfigRegistry template parameter and propagate it to steps via NPM_CONFIG_REGISTRY.
  • Update npm publish job logic so the authenticated .npmrc creation runs only for non-npmjs registries.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/update-docsms-metadata.yml Adds NpmConfigRegistry parameter and exports it as NPM_CONFIG_REGISTRY for the metadata update script.
eng/common/pipelines/templates/steps/create-tags-and-git-release.yml Adds NpmConfigRegistry parameter and exports it as NPM_CONFIG_REGISTRY for the release/tagging script.
eng/common/pipelines/templates/jobs/npm-publish.yml Moves authenticated .npmrc creation into the non-npmjs publishing path (keeps ESRP path for npmjs).

@chidozieononiwu chidozieononiwu merged commit 1b5dbe4 into main Mar 11, 2026
31 checks passed
@chidozieononiwu chidozieononiwu deleted the sync-eng/common-NpmConfigEnvVar-14463 branch March 11, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants