[APIView] Remove ApiKey usage #13235
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
AlitzelMendez
changed the title
There was a problem hiding this comment.
Pull request overview
This PR removes API Key-based authentication from APIView in favor of Azure AD Bearer token authentication. The changes migrate from using a static API key to dynamically acquiring Azure AD tokens via the Azure CLI.
Key Changes:
- Replaced API Key authentication with Azure AD Bearer token authentication using
az account get-access-token - Updated API endpoints to use new lowercase paths (
/autoreview/uploadand/autoreview/create) - Changed HTTP method from GET to POST for the create endpoint to follow RESTful conventions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/common/scripts/Create-APIReview.ps1 | Removed $APIKey parameter, added Get-ApiViewBearerToken() function for Azure AD authentication, updated API endpoints and authentication headers in both upload functions |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changed from Powershell@2 to AzureCLI@2 task to enable Azure authentication context, added AzureServiceConnection parameter, removed API key argument |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Please be sure to follow the eng/common sync workflow to ensure this syncs to all the language repos.
|
/check-enforcer evaluate |
@AlitzelMendez you need to follow the next set of steps https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow let's not override check-enforcer as it shouldn't be needed. |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Alitzel Mendez <[email protected]>
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Alitzel Mendez <[email protected]>
* [DNM][WIP][API View] Remove ApiKey usage * Add -TestAuth flag to verify Bearer token authentication * TEMP: Enable TestAuthOnly for pipeline testing * [APIView] Remove testing logs * Additional clean up * Keep apikey fallback while migrating * [APIView] Keep migration to new endpoint * [APIView] Keep migration to new endpoint * Feedback
second part of: #12484