-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Sync eng/common directory with azure-sdk-tools for PR 13235 #44391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR #13235, implementing a security enhancement that migrates APIView authentication from API Keys to Azure Managed Identity-based Bearer tokens. The changes modernize the authentication mechanism while updating API endpoints to align with the new APIView service contract.
Key Changes:
- Replaced API Key authentication with Azure CLI Bearer Token authentication using Managed Identity
- Updated APIView service endpoints from legacy URLs to new standardized paths
- Changed HTTP methods to match updated API contracts (GET → POST for create operation)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Create-APIReview.ps1 | Removed APIKey parameter; added Get-ApiViewBearerToken function for managed identity authentication; updated API endpoints from /UploadAutoReview to /upload and /CreateApiReview to /create; changed authentication headers from ApiKey to Bearer token; updated HTTP method from GET to POST for create operation |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changed task from Powershell@2 to AzureCLI@2 to support Azure authentication; added Azure subscription configuration; removed APIKey parameter and secret reference |
|
/check-enforcer evaluate |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow