Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow

Copilot AI review requested due to automatic review settings December 11, 2025 17:54
@azure-sdk azure-sdk requested a review from a team as a code owner December 11, 2025 17:54
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with azure-sdk-tools PR #13235, updating APIView integration to use Bearer token authentication with Managed Identity instead of API key-based authentication. This change modernizes the security model by leveraging Azure service connections for authentication rather than storing and managing API keys as pipeline secrets.

Key Changes:

  • Replaced API key authentication with Bearer token authentication obtained via Azure CLI
  • Updated APIView REST API endpoints to use lowercase paths (/autoreview, /upload, /create)
  • Changed HTTP method from GET to POST for the create endpoint to follow REST conventions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/common/scripts/Create-APIReview.ps1 Removed APIKey parameter, added Get-ApiViewBearerToken function for managed identity authentication, updated API endpoint URLs to lowercase, and changed HTTP method to POST for create endpoint
eng/common/pipelines/templates/steps/create-apireview.yml Changed from Powershell@2 task to AzureCLI@2 task with 'APIView prod deployment' service connection, removed APIKey parameter from script arguments

@azure-sdk azure-sdk merged commit c418c07 into main Dec 11, 2025
14 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-stop-using-apikey-13235 branch December 11, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants