Sync eng/common directory with azure-sdk-tools for PR 13235#25764
Merged
Sync eng/common directory with azure-sdk-tools for PR 13235#25764
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR 13235, migrating APIView authentication from API key-based authentication to Bearer token authentication using Azure Managed Identity/Service Principal.
Key Changes:
- Replaced API key authentication with Bearer token authentication using
az account get-access-token - Updated API endpoints to use lowercase paths (
/autoreview,/upload,/create) - Changed HTTP method from GET to POST for the
/createendpoint
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/common/scripts/Create-APIReview.ps1 | Removed $APIKey parameter, added Get-ApiViewBearerToken() function for token acquisition, updated authentication headers to use Bearer tokens, and changed API endpoints and HTTP methods |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changed from Powershell@2 to AzureCLI@2 task to support Azure CLI authentication, added service connection reference, and removed API key parameter from script arguments |
After thoroughly reviewing this pull request, I found no issues. The changes are well-implemented with:
- Proper security improvement: Migration from API key to Managed Identity-based authentication
- Correct task configuration: AzureCLI@2 task is necessary to provide Azure context for
az account get-access-token - Good error handling: Token acquisition failures are properly caught and return appropriate HTTP status codes
- Consistent updates: All references to the old authentication method have been properly removed
- Appropriate API changes: Endpoint updates and HTTP method changes align with the authentication migration
The implementation follows PowerShell best practices and maintains backward compatibility in error handling patterns.
AlitzelMendez
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow