-
Notifications
You must be signed in to change notification settings - Fork 323
Sync eng/common directory with azure-sdk-tools for PR 13235 #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR syncs changes from azure-sdk-tools PR 13235 that migrates the APIView authentication mechanism from API key-based authentication to Azure AD Bearer token authentication using Managed Identity or Service Principal credentials.
Key Changes
- Replaced API key authentication with Azure AD Bearer token authentication via Azure CLI
- Updated APIView endpoints to use lowercase paths (
/autoreview,/upload,/create) - Changed HTTP method from GET to POST for the review token file upload endpoint
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| eng/common/scripts/Create-APIReview.ps1 | Removed APIKey parameter, added Get-ApiViewBearerToken function for Azure AD authentication, updated APIView URI endpoints, and changed HTTP method to POST for review token file uploads |
| eng/common/pipelines/templates/steps/create-apireview.yml | Changed from Powershell@2 task to AzureCLI@2 task with 'APIView prod deployment' service connection, removed APIKey parameter and pwsh property |
|
/check-enforcer evaluate |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13235 See eng/common workflow