[Monitor] Adding multi-dim metrics API, improving error response for Action Groups API, and fixing some documentation typos (from Swagger)#3646
Merged
shahabhijeet merged 17 commits intoAzure:psSdkJson6from Sep 7, 2017
Conversation
… and the corresponding unit tests
… into psSdkJson6 # Conflicts: # src/SDKs/Monitor/Management.Monitor/generate.cmd
…e Resource Manager dll. Enabling tests for netcoreapp1.1
… into MultiDimMetrics # Conflicts: # src/SDKs/Monitor/Management.Monitor/Generated/Monitor/IMetricsOperations.cs # src/SDKs/Monitor/Management.Monitor/Generated/Monitor/MetricsOperations.cs # src/SDKs/Monitor/Management.Monitor/Generated/Monitor/MetricsOperationsExtensions.cs # src/SDKs/Monitor/Management.Monitor/Generated/Monitor/Models/Metric.cs # src/SDKs/Monitor/Management.Monitor/Generated/Monitor/Models/MetricDefinition.cs # src/SDKs/Monitor/Management.Monitor/Properties/AssemblyInfo.cs # src/SDKs/Monitor/Monitor.Tests/BasicTests/MetricsTests.cs # src/SDKs/Monitor/Monitor.Tests/Scenarios/MetricsTests.cs # src/SDKs/Monitor/Monitor.Tests/SessionRecords/Monitor.Tests.Scenarios.MetricsTests/GetMetricDefinitionsTest.json # src/SDKs/Monitor/Monitor.Tests/SessionRecords/Monitor.Tests.Scenarios.MetricsTests/GetMetricsTest.json
…erations do not throw standard exceptions, but return ErrorResponses with more information (PR Azure#1614).
…ror response for Action Groups API.
Contributor
Author
shahabhijeet
suggested changes
Sep 4, 2017
Contributor
shahabhijeet
left a comment
shahabhijeet
left a comment
There was a problem hiding this comment.
Publish will fail if version numbers are not updated
Contributor
Author
|
Sure, I am changing from 0.16.1.0 to 0.17.0.0, Vinicius could use 0.17.0.0 if both changes are merged before we publish since his changes are also significant. Or he could use another version, say 0.17.1.0 if his changes will be backwards compatible or 0.18.0.0 if they are not. |
shahabhijeet
approved these changes
Sep 7, 2017
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
…Action Groups API, and fixing some documentation typos (from Swagger) (Azure#3646) * Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests * Generating code from the 'current' branch of the Swagger specs repo * Adding scenario tests * Improving scenario tests and re-recording them * Making sure the scenario tests point to the more recent version of the Resource Manager dll. Enabling tests for netcoreapp1.1 * Introducing multidimensional metrics API and removing the previous one. * Reverting netcoreapp1.1 test target since it fails to find the records. * Returning generate.md to its Azure\psSdkJson6 state * Re-enabling tests for netcoreapp1.1 * [Monitor] Adding multi-dim metrics API and making sure ActionGroupsOperations do not throw standard exceptions, but return ErrorResponses with more information (PR Azure#1614). * [Monitor] Fixing documentation typos (from Swagger). Improving the error response for Action Groups API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
This PR is related to the Swagger PRs: Azure/azure-rest-api-specs#1620: New Multi-Dim metrics API, and Azure/azure-rest-api-specs#1622: fix typos and change error response.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.